From: "Andreas Färber" <afaerber@suse•de>
To: Gabriel Fernandez <gabriel.fernandez@linaro•org>,
Giuseppe Cavallaro <peppe.cavallaro@st•com>
Cc: netdev@vger•kernel.org, fschaefer.oss@googlemail•com,
Dinh Nguyen <dinh.linux@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Phil Reid <preid@electromag•com.au>
Subject: Re: [PATCH (net-next.git) 2/2] stmmac: fix MDIO settings
Date: Wed, 16 Mar 2016 12:03:14 +0100 [thread overview]
Message-ID: <56E93D72.7060106@suse.de> (raw)
In-Reply-To: <CAG374jDJS7TUSx0Ob38x4aRYHyrA+OWeCDm+f-Ytq8YZhwkEqg@mail.gmail.com>
Am 16.03.2016 um 12:01 schrieb Gabriel Fernandez:
> Hi Pepe,
>
> i have a kernel crash
>
> [ 2.714097] Unable to handle kernel NULL pointer dereference at
> virtual address 000001d6
> [ 2.722188] pgd = c0204000
> [ 2.724886] [000001d6] *pgd=00000000
> [ 2.728452] Internal error: Oops: 5 [#1] SMP ARM
> [ 2.733054] Modules linked in:
> [ 2.736095] CPU: 1 PID: 1 Comm: swapper/0 Not tainted
> 4.5.0-rc7-01768-g3407893 #36
> [ 2.743649] Hardware name: STiH415/416 SoC with Flattened Device Tree
> [ 2.750074] task: ee070000 ti: ee05e000 task.ti: ee05e000
> [ 2.755467] PC is at stmmac_open+0xcc/0xc40
> [ 2.759641] LR is at of_phy_connect+0x44/0x5c
>
>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> index 4c5ce98..943500b 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> @@ -278,7 +278,6 @@ static void stmmac_eee_ctrl_timer(unsigned long arg)
>> */
>> bool stmmac_eee_init(struct stmmac_priv *priv)
>> {
>> - char *phy_bus_name = priv->plat->phy_bus_name;
>> unsigned long flags;
>> bool ret = false;
>>
>> @@ -290,7 +289,7 @@ bool stmmac_eee_init(struct stmmac_priv *priv)
>> goto out;
>>
>> /* Never init EEE in case of a switch is attached */
>> - if (phy_bus_name && (!strcmp(phy_bus_name, "fixed")))
>> + if (priv->phydev->is_pseudo_fixed_link)
>
> priv->phydev is not yet affected
> replace by if (phydev->is_pseudo_fixed_link) instead ?
Indeed that's how I had it in my own patch before. Thanks for spotting.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2016-03-16 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 9:52 [PATCH (net-next.git) 0/2] STMMAC: MDIO settings Giuseppe Cavallaro
2016-03-16 9:52 ` [PATCH (net-next.git) 1/2] Revert "stmmac: Fix 'eth0: No PHY found' regression" Giuseppe Cavallaro
2016-03-16 9:52 ` [PATCH (net-next.git) 2/2] stmmac: fix MDIO settings Giuseppe Cavallaro
2016-03-16 11:01 ` Gabriel Fernandez
2016-03-16 11:03 ` Andreas Färber [this message]
2016-03-16 12:53 ` Giuseppe CAVALLARO
2016-03-16 10:47 ` [PATCH (net-next.git) 0/2] STMMAC: " Andreas Färber
2016-03-16 22:09 ` David Miller
2016-03-17 13:10 ` Giuseppe CAVALLARO
2016-03-18 1:12 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2016-03-16 12:56 [PATCHv2 " Giuseppe Cavallaro
2016-03-16 12:56 ` [PATCH (net-next.git) 2/2] stmmac: fix " Giuseppe Cavallaro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E93D72.7060106@suse.de \
--to=afaerber@suse$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=dinh.linux@gmail$(echo .)com \
--cc=fschaefer.oss@googlemail$(echo .)com \
--cc=gabriel.fernandez@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=preid@electromag$(echo .)com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox