From: Phil Reid <preid@electromag•com.au>
To: Giuseppe CAVALLARO <peppe.cavallaro@st•com>, netdev@vger•kernel.org
Subject: Re: [PATCH 1/1] net: stmmac: Don't search for phys if mdio node is defined.
Date: Wed, 16 Mar 2016 21:18:38 +0800 [thread overview]
Message-ID: <56E95D2E.7010408@electromag.com.au> (raw)
In-Reply-To: <56E9291E.6010503@st.com>
On 16/03/2016 5:36 PM, Giuseppe CAVALLARO wrote:
> On 3/15/2016 8:34 AM, Phil Reid wrote:
>> If a dt mdio entry has been added least assume that we wont
>> search for phys attached. The DT and of_mdiobus_register already do
>> this. This stops DSA phys being found and phys created for them, as
>> this is handled by the DSA driver.
>
> iiuc, this doesn't conflict with the recent rework we are doing
> for the mdio/phy platform management.
It should apply equally well before or after the rework.
>
>> Signed-off-by: Phil Reid <preid@electromag•com.au>
>
> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st•com>
>
>> ---
>> drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
>> index 3f5512f..06704ca 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
>> @@ -235,6 +235,9 @@ int stmmac_mdio_register(struct net_device *ndev)
>> goto bus_register_fail;
>> }
>>
>> + if (priv->plat->phy_node || mdio_node)
>> + goto bus_register_done;
>> +
>> found = 0;
>> for (addr = 0; addr < PHY_MAX_ADDR; addr++) {
>> struct phy_device *phydev = mdiobus_get_phy(new_bus, addr);
>> @@ -290,6 +293,7 @@ int stmmac_mdio_register(struct net_device *ndev)
>> return -ENODEV;
>> }
>>
>> +bus_register_done:
>> priv->mii = new_bus;
>>
>> return 0;
>>
>
>
>
--
Regards
Phil Reid
ElectroMagnetic Imaging Technology Pty Ltd
Development of Geophysical Instrumentation & Software
www.electromag.com.au
3 The Avenue, Midland WA 6056, AUSTRALIA
Ph: +61 8 9250 8100
Fax: +61 8 9250 7100
Email: preid@electromag•com.au
next prev parent reply other threads:[~2016-03-16 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 7:34 [PATCH 0/1] net: stmmac: Don't search for phys if mdio node is defined Phil Reid
2016-03-15 7:34 ` [PATCH 1/1] " Phil Reid
2016-03-16 9:36 ` Giuseppe CAVALLARO
2016-03-16 13:18 ` Phil Reid [this message]
2016-03-18 22:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E95D2E.7010408@electromag.com.au \
--to=preid@electromag$(echo .)com.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox