From: Edward Cree <ecree@solarflare•com>
To: Ben Hutchings <ben@decadent•org.uk>
Cc: <netdev@vger•kernel.org>
Subject: Re: [PATCH ethtool 2/3] Add IPv6 support to NFC
Date: Wed, 16 Mar 2016 14:53:43 +0000 [thread overview]
Message-ID: <56E97377.4030400@solarflare.com> (raw)
In-Reply-To: <1457887406.3331.31.camel@decadent.org.uk>
On 13/03/16 16:43, Ben Hutchings wrote:
> On Mon, 2016-02-15 at 14:59 +0000, Edward Cree wrote:
>> Signed-off-by: Edward Cree <ecree@solarflare•com>
> [...]
>> @@ -950,6 +1154,19 @@ static int rxclass_get_mask(char *str, unsigned char *p,
>> *(__be32 *)&p[opt->moffset] = ~val;
>> break;
>> }
>> + case OPT_IP6: {
>> + __be32 val[4];
>> + int i;
>> + err = rxclass_get_ipv6(str, val);
>> + if (err)
>> + return -1;
>> + for (i = 0; i < 4; i++) {
>> + ((__be32 *)&p[opt->offset])[i] = val[i];
>> + if (opt->moffset >= 0)
>> + ((__be32 *)&p[opt->moffset])[i] = ~val[i];
> This pointer arithmetic looks terrible. I think memcpy() would be much
> clearer here.
I've changed the version in rxclass_get_val to use memcpy() (and memset() the
mask). Unfortunately, we can't do that here, because we need to complement
the mask valueas we go, and afaik there's no library function to copy-and-
complement a byte array.
Glibc does, however, have a function memfrob(), which XORs every byte of an
arraywiththe constant 42. Useful feature, that.
On the other hand, the quoted code is still wrong because it's also writing
throughopt->offset and checking for opt->moffset>= 0, both daft copy-and-
paste errors onmypart. Will fix in next version.
> I won't apply patches labelled as "confidential". You need to stop
> including this nonsense in your public messages (I thought you fixed
> this once before).
In theory it's been fixed harder now - please let me know if not.
-Ed
next prev parent reply other threads:[~2016-03-16 15:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 14:56 [PATCH ethtool 0/3] IPv6 RXNFC Edward Cree
2016-02-15 14:59 ` [PATCH ethtool 1/3] ethtool-copy.h: sync with net-next Edward Cree
2016-02-15 14:59 ` [PATCH ethtool 2/3] Add IPv6 support to NFC Edward Cree
2016-03-13 16:43 ` Ben Hutchings
2016-03-16 14:53 ` Edward Cree [this message]
2016-03-16 17:15 ` Ben Hutchings
2016-02-15 15:00 ` [PATCH ethtool 3/3] Documentation for IPv6 NFC Edward Cree
2016-03-13 16:47 ` Ben Hutchings
2016-03-16 14:54 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E97377.4030400@solarflare.com \
--to=ecree@solarflare$(echo .)com \
--cc=ben@decadent$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox