From: Florian Fainelli <f.fainelli@gmail•com>
To: Eric Dumazet <eric.dumazet@gmail•com>,
David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, opendmb@gmail•com
Subject: Re: [PATCH net] net: bcmgenet: fix dma api length mismatch
Date: Thu, 17 Mar 2016 16:16:48 -0700 [thread overview]
Message-ID: <56EB3AE0.5030604@gmail.com> (raw)
In-Reply-To: <1458241026.7353.62.camel@edumazet-glaptop3.roam.corp.google.com>
On 17/03/16 11:57, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google•com>
>
> When un-mapping skb->data in __bcmgenet_tx_reclaim(),
> we must use the length that was used in original dma_map_single(),
> instead of skb->len that might be bigger (includes the frags)
>
> We simply can store skb_len into tx_cb_ptr->dma_len and use it
> at unmap time.
>
> Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
> Signed-off-by: Eric Dumazet <edumazet@google•com>
Acked-by: Florian Fainelli <f.fainelli@gmail•com>
Good catch, thanks!
--
Florian
next prev parent reply other threads:[~2016-03-17 23:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 14:18 [BUG] bcmgenet tx path Eric Dumazet
2016-03-17 17:00 ` Florian Fainelli
2016-03-17 18:57 ` [PATCH net] net: bcmgenet: fix dma api length mismatch Eric Dumazet
2016-03-17 23:16 ` Florian Fainelli [this message]
2016-03-19 3:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EB3AE0.5030604@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=opendmb@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox