Subject: Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 21 Mar 2016 17:17:49 +0300

Hello.

On 03/21/2016 02:06 PM, Yisen Zhuang wrote:

> From: Kejian Yan <[email-masked]>
>
> If mtu for debug port is set more than 1500, it may cause that packets
> are dropped by ppe. So maximum value for debug port should be 1500.
>
> Signed-off-by: Kejian Yan <[email-masked]>
> Signed-off-by: Yisen Zhuang <[email-masked]>
[...]
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
> index a69c8af..a68efd6 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
> @@ -28,6 +28,7 @@ struct dsaf_device;
>   #define MAC_MAX_MTU		9600
>   #define MAC_MAX_MTU_V2		9728
>   #define MAC_MIN_MTU		68
> +#define MAC_MAX_MTU_DBG         MAC_DEFAULT_MTU

    Please use tabs, not spaces to indent the value, like above

[...]

MBR, Sergei