Subject: Re: [PATCH] macb: fix PHY reset

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 22 Mar 2016 22:34:05 +0300

On 03/22/2016 10:27 PM, Sergei Shtylyov wrote:

> The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and 1, as
> a result the PHY isn't really  put back into reset state in macb_remove().
> Moreover, the driver assumes that something else has set the GPIO direction
> to output, so if  it has not, the PHY wouldn't be taken out of reset in

    s/wouldn't/may not/, sorry. Do I need to resend?

> macb_probe() either...
>
> Signed-off-by: Sergei Shtylyov <[email-masked]>

MBR, Sergei