From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: David Miller <davem@redhat•com>
Cc: netdev@vger•kernel.org, nicolas.ferre@atmel•com
Subject: Re: [PATCH] macb: fix PHY reset
Date: Wed, 23 Mar 2016 00:04:53 +0300 [thread overview]
Message-ID: <56F1B375.7040502@cogentembedded.com> (raw)
In-Reply-To: <20160322.160738.145737905213296810.davem@redhat.com>
On 03/22/2016 11:07 PM, David Miller wrote:
>>> The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and
>>> 1, as
>>> a result the PHY isn't really put back into reset state in
>>> macb_remove().
>>> Moreover, the driver assumes that something else has set the GPIO
>>> direction
>>> to output, so if it has not, the PHY wouldn't be taken out of reset in
>>
>> s/wouldn't/may not/, sorry. Do I need to resend?
>
> No need, I fixed it up by hand.
>
> Applied, thanks.
Thank you! gpio_request() or smth of that sort wouldn't hurt too (the pin
won't be switched to the GPIO mode on the pin function controller that I have
here...
Anyway, this code is doomed if my phylib reset GPIO patch (to be posted
yet) is accepted ...
MBR, Sergei
next prev parent reply other threads:[~2016-03-22 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 19:27 [PATCH] macb: fix PHY reset Sergei Shtylyov
2016-03-22 19:34 ` Sergei Shtylyov
2016-03-22 20:07 ` David Miller
2016-03-22 21:04 ` Sergei Shtylyov [this message]
2016-03-22 21:33 ` Sergei Shtylyov
2016-03-23 8:54 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F1B375.7040502@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@atmel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox