From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Quentin Armitage <quentin@armitage•org.uk>,
"David S. Miller" <davem@davemloft•net>,
Alexey Kuznetsov <kuznet@ms2•inr.ac.ru>,
James Morris <jmorris@namei•org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
Patrick McHardy <kaber@trash•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH] net: remove unimplemented RTNH_F_PERVASIVE
Date: Sat, 2 Apr 2016 19:04:27 +0300 [thread overview]
Message-ID: <56FFED8B.7010701@cogentembedded.com> (raw)
In-Reply-To: <1459586603-24006-1-git-send-email-quentin@armitage.org.uk>
Hello.
On 4/2/2016 11:43 AM, Quentin Armitage wrote:
> Linux 2.1.68 introduced RTNH_F_PERVASIVE, but it had no implementation
> and couldn't be enabled since the required config parameter wasn't in
> any Kconfig file (see commit d088dde7b).
scripts/checkpatch.pl now enforces certain commit citing format, your
doesn't match it, i.e. you need 12-digit SHA1 and ("<commit summary") after that.
> This commit removes all remaining references to RTNH_F_PERVASIVE.
> Although this will cause userspace applications that were using the
> flag to fail to build, they will be alerted to the fact that using
> RTNH_F_PERVASIVE was not achieving anything.
>
> Signed-off-by: Quentin Armitage <quentin@armitage•org.uk>
[...]
> diff --git a/net/decnet/dn_fib.c b/net/decnet/dn_fib.c
> index df48034..f5660c6 100644
> --- a/net/decnet/dn_fib.c
> +++ b/net/decnet/dn_fib.c
> @@ -243,7 +243,7 @@ out:
> } else {
> struct net_device *dev;
>
> - if (nh->nh_flags&(RTNH_F_PERVASIVE|RTNH_F_ONLINK))
> + if (nh->nh_flags&RTNH_F_ONLINK)
Please enclose & into spaces like below.
> diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
> index d97268e..3883860 100644
> --- a/net/ipv4/fib_semantics.c
> +++ b/net/ipv4/fib_semantics.c
> @@ -803,7 +803,7 @@ static int fib_check_nh(struct fib_config *cfg, struct fib_info *fi,
> } else {
> struct in_device *in_dev;
>
> - if (nh->nh_flags & (RTNH_F_PERVASIVE | RTNH_F_ONLINK))
> + if (nh->nh_flags & RTNH_F_ONLINK)
> return -EINVAL;
>
> rcu_read_lock();
MBR, Sergei
next prev parent reply other threads:[~2016-04-02 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 8:43 [PATCH] net: remove unimplemented RTNH_F_PERVASIVE Quentin Armitage
2016-04-02 16:04 ` Sergei Shtylyov [this message]
2016-04-02 16:51 ` [PATCH v2] " Quentin Armitage
2016-04-05 23:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FFED8B.7010701@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=quentin@armitage$(echo .)org.uk \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox