From: Amir Vadai <amir@vadai•me>
To: John Fastabend <john.fastabend@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org,
John Fastabend <john.r.fastabend@intel•com>,
Or Gerlitz <ogerlitz@mellanox•com>,
Hadar Har-Zion <hadarh@mellanox•com>,
Jiri Pirko <jiri@mellanox•com>,
Jamal Hadi Salim <jhs@mojatatu•com>
Subject: Re: [RFC net-next 6/9] net/cls_flower: Introduce hardware offloading
Date: Mon, 1 Feb 2016 12:43:08 +0200 [thread overview]
Message-ID: <56af360f.034cc20a.78f42.3c3c@mx.google.com> (raw)
In-Reply-To: <56AF25E5.6000105@gmail.com>
On Mon, Feb 01, 2016 at 01:31:17AM -0800, John Fastabend wrote:
> On 16-02-01 12:34 AM, Amir Vadai wrote:
> > During initialization, tcf_exts_offload_init() is called to initialize
> > the list of actions description. later on, the classifier description
> > is prepared and sent to the switchdev using switchdev_port_flow_add().
> >
> > When offloaded, fl_classify() is a NOP - already done in hardware.
> >
> > Signed-off-by: Amir Vadai <amir@vadai•me>
> > ---
>
> You need to account for where the classifier is being loaded
> by passing the handle as I did in my patch set. Otherwise you may
> be offloading on egress/ingress or even some qdisc multiple layers
> down in the hierarchy.
Right. Will fix it.
>
> .John
>
next prev parent reply other threads:[~2016-02-01 10:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 8:34 [RFC net-next 0/9] TC filter HW offloads Amir Vadai
2016-02-01 8:34 ` [RFC net-next 1/9] net/flow_dissector: Make dissector_uses_key() and skb_flow_dissector_target() public Amir Vadai
2016-02-01 8:34 ` [RFC net-next 2/9] net/switchdev: Introduce hardware offload support Amir Vadai
2016-02-01 9:06 ` Jiri Pirko
2016-02-01 9:11 ` amirva
2016-02-01 9:26 ` John Fastabend
2016-02-01 8:34 ` [RFC net-next 3/9] net/act: Offload support by tc actions Amir Vadai
2016-02-01 8:34 ` [RFC net-next 4/9] net/act_skbedit: Introduce hardware offload support Amir Vadai
2016-02-01 8:34 ` [RFC net-next 5/9] net/act_gact: Introduce hardware offload support for drop Amir Vadai
2016-02-01 8:34 ` [RFC net-next 6/9] net/cls_flower: Introduce hardware offloading Amir Vadai
2016-02-01 9:31 ` John Fastabend
2016-02-01 9:47 ` John Fastabend
2016-02-01 10:43 ` Amir Vadai [this message]
2016-02-01 21:25 ` John Fastabend
2016-02-01 8:34 ` [RFC net-next 7/9] net/mlx5_core: Go to next flow table support Amir Vadai
2016-02-01 8:34 ` [RFC net-next 8/9] net/mlx5e: Introduce MLX5_FLOW_NAMESPACE_OFFLOADS Amir Vadai
2016-02-01 8:34 ` [RFC net-next 9/9] net/mlx5e: Flow steering support through switchdev Amir Vadai
2016-02-01 18:52 ` Saeed Mahameed
2016-02-01 21:45 ` Or Gerlitz
2016-02-01 9:21 ` [RFC net-next 0/9] TC filter HW offloads John Fastabend
2016-02-01 14:37 ` Amir Vadai
2016-02-01 19:59 ` Tom Herbert
2016-02-01 20:14 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56af360f.034cc20a.78f42.3c3c@mx.google.com \
--to=amir@vadai$(echo .)me \
--cc=davem@davemloft$(echo .)net \
--cc=hadarh@mellanox$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox