From: Amir Vadai <amir@vadai•me>
To: Jiri Pirko <jiri@resnulli•us>
Cc: "David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, Or Gerlitz <ogerlitz@mellanox•com>,
John Fastabend <john.r.fastabend@intel•com>,
Saeed Mahameed <saeedm@mellanox•com>,
Hadar Har-Zion <hadarh@mellanox•com>,
Jiri Pirko <jiri@mellanox•com>
Subject: Re: [PATCH net-next 8/8] net/mlx5e: Support offload cls_flower with sskbedit mark action
Date: Tue, 1 Mar 2016 18:53:43 +0200 [thread overview]
Message-ID: <56d5c81e.46fac20a.5f8c7.ffffd9fc@mx.google.com> (raw)
In-Reply-To: <20160301145810.GE2098@nanopsycho.orion>
On Tue, Mar 01, 2016 at 03:58:10PM +0100, Jiri Pirko wrote:
> Tue, Mar 01, 2016 at 03:24:50PM CET, amir@vadai•me wrote:
> >Introduce offloading of skbedit mark action.
> >
> >For example, to mark with 0x1234, all TCP (ip_proto 6) packets arriving
> >to interface ens9:
> >
> > # tc qdisc add dev ens9 ingress
> > # tc filter add dev ens9 protocol ip parent ffff: \
> > flower ip_proto 6 \
> > indev ens9 \
> > action skbedit mark 0x1234
> >
>
> <snip>
>
> >@@ -287,6 +288,21 @@ static int parse_tc_actions(struct mlx5e_priv *priv, struct tcf_exts *exts,
> > continue;
> > }
> >
> >+ if (is_tcf_skbedit_mark(a)) {
> >+ u32 mark = tcf_skbedit_mark(a);
> >+
> >+ if (mark & ~MLX5E_TC_FLOW_ID_MASK) {
> >+ netdev_warn(priv->netdev,
> >+ "Bad flow mark - only 16 bit is supported: 0x%x\n",
>
> You can start printk string on the first line.
ack
next prev parent reply other threads:[~2016-03-01 16:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 14:24 [PATCH net-next 0/8] cls_flower hardware offload support Amir Vadai
2016-03-01 14:24 ` [PATCH net-next 1/8] net/flower: Introduce " Amir Vadai
2016-03-01 14:47 ` Jiri Pirko
2016-03-01 16:49 ` Amir Vadai
2016-03-01 17:01 ` Jiri Pirko
2016-03-02 11:14 ` Or Gerlitz
2016-03-02 13:22 ` Jiri Pirko
2016-03-02 16:22 ` John Fastabend
2016-03-02 16:30 ` Jiri Pirko
2016-03-01 14:53 ` Jiri Pirko
2016-03-01 16:50 ` Amir Vadai
2016-03-01 14:24 ` [PATCH net-next 2/8] net/flow_dissector: Make dissector_uses_key() and skb_flow_dissector_target() public Amir Vadai
2016-03-01 14:24 ` [PATCH net-next 3/8] net/act_skbedit: Utility functions for mark action Amir Vadai
2016-03-01 14:24 ` [PATCH net-next 4/8] net/mlx5_core: Set flow steering dest only for forward rules Amir Vadai
2016-03-01 14:24 ` [PATCH net-next 5/8] net/mlx5e: Add a new priority for kernel flow tables Amir Vadai
2016-03-01 14:24 ` [PATCH net-next 6/8] net/mlx5e: Introduce tc offload support Amir Vadai
2016-03-01 14:52 ` Jiri Pirko
2016-03-01 17:00 ` Amir Vadai
2016-03-01 17:13 ` John Fastabend
2016-03-02 15:53 ` Amir Vadai
2016-03-02 15:58 ` Jiri Pirko
2016-03-01 15:59 ` Saeed Mahameed
2016-03-01 17:07 ` Amir Vadai
2016-03-01 14:24 ` [PATCH net-next 7/8] net/mlx5e: Support offload cls_flower with drop action Amir Vadai
2016-03-01 14:55 ` Jiri Pirko
2016-03-01 16:50 ` Amir Vadai
2016-03-01 15:03 ` Jiri Pirko
2016-03-01 14:24 ` [PATCH net-next 8/8] net/mlx5e: Support offload cls_flower with sskbedit mark action Amir Vadai
2016-03-01 14:58 ` Jiri Pirko
2016-03-01 16:53 ` Amir Vadai [this message]
2016-03-01 17:18 ` [PATCH net-next 0/8] cls_flower hardware offload support John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56d5c81e.46fac20a.5f8c7.ffffd9fc@mx.google.com \
--to=amir@vadai$(echo .)me \
--cc=davem@davemloft$(echo .)net \
--cc=hadarh@mellanox$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=saeedm@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox