Subject: Re: [PATCH net-next] cxgb4/cxgb4vf: Deprecate module parameter dflt_msg_enable

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 4 Apr 2016 15:43:09 +0300

Hello.

On 4/4/2016 7:53 AM, Hariprasad Shenai wrote:

> Message level can be set through ethtool, so deprecate module parameter
> which is used to set the same.
>
> Signed-off-by: Hariprasad Shenai <[email-masked]>
> ---
>   drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c     | 3 ++-
>   drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 3 ++-
>   2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> index d1e3f0997d6b..acefa35b7250 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> @@ -168,7 +168,8 @@ MODULE_PARM_DESC(force_init, "Forcibly become Master PF and initialize adapter,"
>   static int dflt_msg_enable = DFLT_MSG_ENABLE;
>
>   module_param(dflt_msg_enable, int, 0644);
> -MODULE_PARM_DESC(dflt_msg_enable, "Chelsio T4 default message enable bitmap");
> +MODULE_PARM_DESC(dflt_msg_enable, "Chelsio T4 default message enable bitmap,"

    Need space after the last comma...

> +		 "deprecated parameter");
>
>   /*
>    * The driver uses the best interrupt scheme available on a platform in the
> diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> index 1cc8a7a69457..730fec73d5a6 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> @@ -74,7 +74,8 @@ static int dflt_msg_enable = DFLT_MSG_ENABLE;
>
>   module_param(dflt_msg_enable, int, 0644);
>   MODULE_PARM_DESC(dflt_msg_enable,
> -		 "default adapter ethtool message level bitmap");
> +		 "default adapter ethtool message level bitmap, "

    ... like here.

> +		 "deprecated parameter");
>
>   /*
>    * The driver uses the best interrupt scheme available on a platform in the

MBR, Sergei