From: oulijun <oulijun-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>
To: <dledford-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>,
<sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>,
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
<jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>,
<jiri-VPRAkNaXOzVWk0Htik3J/w@public•gmane.org>,
<ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public•gmane.org>,
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<gongyangming-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<xiaokun-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<tangchaofei-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<haifeng.wei-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<yisen.zhuang-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<yankejian-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<lisheng011-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<charles.chenxin-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<linuxarm-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>
Subject: Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support
Date: Tue, 5 Apr 2016 15:32:53 +0800 [thread overview]
Message-ID: <57036A25.9000106@huawei.com> (raw)
In-Reply-To: <20160402015830.GD8565-2ukJVAZIZ/Y@public.gmane.org>
Hi, Leon Romanovsky
On 2016/4/2 9:58, Leon Romanovsky wrote:
> On Fri, Apr 01, 2016 at 05:21:31PM +0800, Lijun Ou wrote:
>> The driver for HiSilicon RoCE is a platform driver.
>> The driver will support multiple versions of hardware. Currently only "v1"
>> for hip06 SoC is supported.
>> The driver includes two parts: common driver and hardware-specific
>> operations. hns_roce_v1_hw.c and hns_roce_v1_hw.h are files for
>> hardware-specific operations only for v1 engine, and other files(.c and .h)
>> for common algorithm and common hardware operations.
>>
>> Signed-off-by: Lijun Ou <oulijun-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>
>> Signed-off-by: Wei Hu(Xavier) <xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>
>> Signed-off-by: Znlong <zhaonenglong-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>
>> ---
>> MAINTAINERS | 8 +
>> drivers/infiniband/Kconfig | 1 +
>> drivers/infiniband/hw/Makefile | 1 +
>> drivers/infiniband/hw/hisilicon/hns/Kconfig | 10 +
>> drivers/infiniband/hw/hisilicon/hns/Makefile | 9 +
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c | 110 +
>
> We are not adding name of company (hisilicon) for infiniband HW drivers
> drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c
> --->
> drivers/infiniband/hw/hns/hns_roce_ah.c
>
Surely, i will modify the location of RoCE driver code after disscussed in next patch
>
>> .../infiniband/hw/hisilicon/hns/hns_roce_alloc.c | 239 ++
> ^^^^^^
> Please fix you paths.
>
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.c | 338 +++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.h | 80 +
>> .../infiniband/hw/hisilicon/hns/hns_roce_common.h | 308 +++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_cq.c | 436 +++
>> .../infiniband/hw/hisilicon/hns/hns_roce_device.h | 794 ++++++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.c | 758 ++++++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.h | 132 +
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.c | 578 ++++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.h | 112 +
>> .../infiniband/hw/hisilicon/hns/hns_roce_main.c | 1097 ++++++++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_mr.c | 605 +++++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_pd.c | 124 +
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_qp.c | 841 ++++++
>> .../infiniband/hw/hisilicon/hns/hns_roce_user.h | 31 +
>> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 ++++++++++++++++++++
>> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++++++
> ^^^^^^
> Do you support v1 of RoCE or v1 of your HW?
>
Here, v1 stands for hw, that is, we support v1 of our hw.
>> 23 files changed, 10429 insertions(+)
>
> Please appreciate the effort needed to review such large patch and
> invest time and effort to divide this to number of small easy review patches.
>
Surely, i have pay attention to the patch, but i consider that it is not better to
split the patch into small patch. because it will the base function of RoCE.
For your advice, i will make further efforts to taking a discussion how to reslove the question.
thanks
Lijun Ou
> .
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-05 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 9:21 [RESEND PATCH V4 0/3] IB/hns: Add HiSilicon RoCE driver Lijun Ou
2016-04-01 9:21 ` [RESEND PATCH V4 1/3] net: hns: Add reset function support for " Lijun Ou
2016-04-01 9:21 ` [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support Lijun Ou
[not found] ` <1459502492-19891-3-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-04-02 1:58 ` Leon Romanovsky
[not found] ` <20160402015830.GD8565-2ukJVAZIZ/Y@public.gmane.org>
2016-04-05 7:32 ` oulijun [this message]
2016-04-05 15:32 ` Leon Romanovsky
2016-04-01 9:21 ` [RESEND PATCH V4 3/3] IB/hns: Add binding document for HiSilicon RoCE driver Lijun Ou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57036A25.9000106@huawei.com \
--to=oulijun-hv44wf8li93qt0dzr+alfa@public$(echo .)gmane.org \
--cc=charles.chenxin-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=gongyangming-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=haifeng.wei-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=jiri-VPRAkNaXOzVWk0Htik3J/w@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linuxarm-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=lisheng011-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public$(echo .)gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=tangchaofei-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=xiaokun-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=yankejian-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=yisen.zhuang-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox