From: David Ahern <dsa@cumulusnetworks•com>
To: Eric Dumazet <eric.dumazet@gmail•com>,
David Miller <davem@davemloft•net>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>, edumazet@google•com
Subject: Re: [PATCH net-next] tcp/dccp: fix inet_reuseport_add_sock()
Date: Thu, 7 Apr 2016 08:18:51 -0600 [thread overview]
Message-ID: <57066C4B.6050108@cumulusnetworks.com> (raw)
In-Reply-To: <1460005654.6473.377.camel@edumazet-glaptop3.roam.corp.google.com>
On 4/6/16 11:07 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google•com>
>
> David Ahern reported panics in __inet_hash() caused by my recent commit.
>
> The reason is inet_reuseport_add_sock() was still using
> sk_nulls_for_each_rcu() instead of sk_for_each_rcu().
> SO_REUSEPORT enabled listeners were causing an instant crash.
>
> While chasing this bug, I found that I forgot to clear SOCK_RCU_FREE
> flag, as it is inherited from the parent at clone time.
>
> Fixes: 3b24d854cb35 ("tcp/dccp: do not touch listener sk_refcnt under synflood")
> Signed-off-by: Eric Dumazet <edumazet@google•com>
> Reported-by: David Ahern <dsa@cumulusnetworks•com>
> ---
Fixed the problem I as hiting.
Tested-by: David Ahern <dsa@cumulusnetworks•com>
next prev parent reply other threads:[~2016-04-07 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 0:02 panic in __inet_hash David Ahern
2016-04-07 5:07 ` [PATCH net-next] tcp/dccp: fix inet_reuseport_add_sock() Eric Dumazet
2016-04-07 14:18 ` David Ahern [this message]
2016-04-07 16:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57066C4B.6050108@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox