From: Nikolay Aleksandrov via Bridge <bridge@lists•linux-foundation.org>
To: Xin Long <lucien.xin@gmail•com>,
network dev <netdev@vger•kernel.org>,
bridge@lists•linux-foundation.org
Cc: davem@davemloft•net
Subject: Re: [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl
Date: Sat, 9 Apr 2016 14:55:24 +0200 [thread overview]
Message-ID: <5708FBBC.7000106@cumulusnetworks.com> (raw)
In-Reply-To: <cover.1460131308.git.lucien.xin@gmail.com>
On 04/08/2016 06:03 PM, Xin Long wrote:
> This patchset is used to support sending rntl info to user in some places,
> and ensure that whenever those attributes change internally or from sysfs,
> that a netlink notification is sent out to listeners.
>
> It also make some adjustment in bridge sysfs so that we can implement this
> easily.
>
> I've done some tests on this patchset, like:
> [br_sysfs]
> 1. change all the attribute values of br or brif:
> $ echo $value > /sys/class/net/br0/bridge/{*}
> $ echo $value > /sys/class/net/br0/brif/eth1/{*}
>
> 2. meanwhile, on another terminal to observe the msg:
> $ bridge monitor
>
> [br_ioctl]
> 1. in bridge-utils package, do some changes in br_set, let brctl command
> use ioctl to set attribute:
> if ((ret = set_sysfs(path, value)) < 0) { -->
> if (1) {
>
> $ brctl set*
>
> 2. meanwhile, on another terminal to observe the msg:
> $ bridge monitor
>
> This test covers all the attributes that brctl and sysfs support to set.
>
Overall the set looks good to me, just one comment for future posts - please
include the changes between versions of the set in your cover letter and
individual patches. I had to go back to your previous postings and read my
own comments and compare them with this set.
Thank you,
Nik
next prev parent reply other threads:[~2016-04-09 12:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 16:03 [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl Xin Long
2016-04-08 16:03 ` [PATCHv3 net-next 1/6] bridge: simplify the flush_store by calling store_bridge_parm Xin Long
2016-04-09 12:27 ` Nikolay Aleksandrov via Bridge
2016-04-08 16:03 ` [PATCHv3 net-next 2/6] bridge: simplify the forward_delay_store " Xin Long
2016-04-09 12:31 ` Nikolay Aleksandrov via Bridge
2016-04-08 16:03 ` [PATCHv3 net-next 3/6] bridge: simplify the stp_state_store " Xin Long
2016-04-09 12:33 ` Nikolay Aleksandrov via Bridge
2016-04-08 16:03 ` [PATCHv3 net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br Xin Long
2016-04-09 12:41 ` Nikolay Aleksandrov via Bridge
2016-04-08 16:03 ` [PATCHv3 net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if Xin Long
2016-04-09 12:45 ` Nikolay Aleksandrov via Bridge
2016-04-08 16:03 ` [PATCHv3 net-next 6/6] bridge: a netlink notification should be sent when those attributes are changed by ioctl Xin Long
2016-04-09 12:49 ` Nikolay Aleksandrov via Bridge
2016-04-09 12:55 ` Nikolay Aleksandrov via Bridge [this message]
2016-04-14 2:42 ` [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5708FBBC.7000106@cumulusnetworks.com \
--to=bridge@lists$(echo .)linux-foundation.org \
--cc=davem@davemloft$(echo .)net \
--cc=lucien.xin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox