Subject: Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

From: Jamal Hadi Salim <[email-masked]>
Date: Wed, 13 Apr 2016 08:11:48 -0400

On 16-04-12 09:21 AM, Thomas Graf wrote:
> On 04/11/16 at 08:53pm, roopa wrote:
>> Top level stats attributes can be netdev or global attributes: We can include string "LINK" in
>> the names of all stats belonging to a netdev to make it easier to recognize the netdev stats (example):
>>   IFLA_STATS_LINK64,           (netdev)
>>   IFLA_STATS_LINK_INET6,    (netdev)
>>   IFLA_STATS_TCP,                (non-netdev, global tcp stats)
>
> This is fine as well. It means that we cant mix netdev and non-netdev
> stats or stats for multiple netdevs in the same request which would
> not be the case if you nest it and have a top level attribute which
> is a list of requests. That may be borderline to overengineering
> though so I'm fine this as well.

Well - using a subheader which has ifindex on it for non-netdev stats
seems wrong then.

cheers,
jamal