From: David Ahern <dsa@cumulusnetworks•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next] net: ipv6: Use passed in table for nexthop lookups
Date: Wed, 13 Apr 2016 22:07:28 -0600 [thread overview]
Message-ID: <570F1780.20606@cumulusnetworks.com> (raw)
In-Reply-To: <20160413.214151.2294488534397440295.davem@davemloft.net>
On 4/13/16 7:41 PM, David Miller wrote:
> This is semantically different from the referenced ipv4 change.
>
> Lack of a matching table for cfg->fc_table does not result in a
> failure on the ipv4 side. It falls back in that case.
>
> But here in this ipv6 patch, you do fail if fib6_get_table() gives
> NULL.
Unintentional. I meant for this to behave exactly like the ipv4 change.
>
> One thing that drives me absolutely crazy is all of the subtle
> semantic differences between our ipv4 and ipv6 stack, so I refuse to
> knowingly add new such cases.
I feel that pain on a daily basis.
>
> Therefore, please make the ipv6 behavior match exactly what ipv4
> does.
Will remove the goto out on the table lookup fail and have it fallback
to current logic. Thanks for catching that difference.
prev parent reply other threads:[~2016-04-14 4:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 18:11 [PATCH net-next] net: ipv6: Use passed in table for nexthop lookups David Ahern
2016-04-14 1:41 ` David Miller
2016-04-14 4:07 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570F1780.20606@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox