From: David Ahern <dsa@cumulusnetworks•com>
To: Mike Manning <mmanning@brocade•com>, netdev@vger•kernel.org
Subject: Re: [PATCH] net: ipv6: Do not fix up linklocal and loopback addresses
Date: Mon, 18 Apr 2016 08:39:21 -0600 [thread overview]
Message-ID: <5714F199.7020608@cumulusnetworks.com> (raw)
In-Reply-To: <5714EDDB.8080306@brocade.com>
On 4/18/16 8:23 AM, Mike Manning wrote:
> f1705ec197e7 "Make address flushing on ifdown optional" added the option
> to retain user configured addresses on an admin down. A comment to one of
> the later revisions suggested using the IFA_F_PERMANENT flag rather than
> adding a user_managed boolean to the ifaddr struct. A side effect of this
> change is that link local and loopback addresses were also retained which
> was not part of the objective of the original changes. The fix 70af921db6f8
> "Do not keep linklocal and loopback addresses" ensures that these are no
> longer kept. Similarly, the present fix ensures that these addresses are not
> fixed up either, otherwise the incorrect fixup triggers a crash in fib6.
>
> Fixes: f1705ec197e7 ("net: ipv6: Make address flushing on ifdown optional")
> Signed-off-by: Mike Manning <mmanning@brocade•com>
> ---
> net/ipv6/addrconf.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
Is this a v2? Code change is the same.
Acked-by: David Ahern <dsa@cumulusnetworks•com>
next prev parent reply other threads:[~2016-04-18 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5711AA52.6010400@brocade.com>
2016-04-16 3:13 ` [PATCH] net: ipv6: Do not fix up linklocal and loopback addresses Mike Manning
2016-04-16 14:31 ` Sergei Shtylyov
2016-04-16 18:26 ` David Ahern
2016-04-17 18:13 ` Mike Manning
2016-04-18 14:23 ` Mike Manning
2016-04-18 14:39 ` David Ahern [this message]
2016-04-18 15:14 ` Mike Manning
2016-04-18 15:19 ` Sergei Shtylyov
2016-04-18 15:28 ` Mike Manning
[not found] <571A4D11.8070307@brocade.com>
2016-04-22 16:14 ` Mike Manning
2016-04-22 22:14 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5714F199.7020608@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=mmanning@brocade$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox