From: David Ahern <dsa@cumulusnetworks•com>
To: Ilan Tayari <ilant@mellanox•com>, Jiri Pirko <jiri@resnulli•us>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: switchdev fib offload issues
Date: Mon, 18 Apr 2016 11:11:26 -0600 [thread overview]
Message-ID: <5715153E.6060005@cumulusnetworks.com> (raw)
In-Reply-To: <AM4PR0501MB19409325D618C1C2E9519E9FDB6B0@AM4PR0501MB1940.eurprd05.prod.outlook.com>
On 4/18/16 10:38 AM, Ilan Tayari wrote:
> Hi Jiri,
>
>> Thoughts?
>
> One general thought comes to mind, regardless of your proposed solutions:
>
> You'll need to take care to propagate the error properly in case of routes created by the kernel, such as local routes.
> Local routes are created when an IP address is added to an interface, so in such a case would the whole add-ip-address operation be rolled back cleanly?
local routes are added on an 'admin up' too which is completely
disconnected from adding the address to the interface.
next prev parent reply other threads:[~2016-04-18 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 15:47 switchdev fib offload issues Jiri Pirko
2016-04-18 16:38 ` Ilan Tayari
2016-04-18 17:11 ` David Ahern [this message]
2016-04-18 16:59 ` David Ahern
2016-04-19 7:02 ` Jiri Pirko
2016-04-18 17:17 ` Hannes Frederic Sowa
2016-04-21 13:00 ` Roopa Prabhu
2016-04-18 17:52 ` David Miller
2016-04-19 7:21 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5715153E.6060005@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=ilant@mellanox$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox