Subject: Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings

From: Florian Fainelli <[email-masked]>
Date: Fri, 6 May 2016 16:41:33 -0700

On 06/05/16 16:18, Philippe Reynes wrote:
> The callback {get|set}_link_ksettings are often defined
> in a very close way. There are mainly two differences in
> those callback:
> - the name of the netdev private structure
> - the name of the struct phydev in the private structure
> 
> We add two defines ethtool_phy_{get|set}_link_ksettings
> to avoid writing severals times almost the same function.

This looks fine in principle, but then there is a whole ton of code that
could become like that in the kernel, I do not have any strong opinion
either way...
-- 
Florian