public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks•com>
To: netdev@vger•kernel.org
Subject: Re: [PATCH net-next 0/2] net: vrf: Fixup PKTINFO to return enslaved device index
Date: Fri, 6 May 2016 19:04:47 -0600	[thread overview]
Message-ID: <572D3F2F.4030307@cumulusnetworks.com> (raw)
In-Reply-To: <1462477063-21699-1-git-send-email-dsa@cumulusnetworks.com>

On 5/5/16 1:37 PM, David Ahern wrote:
> Applications such as OSPF and BFD need the original ingress device not
> the VRF device; the latter can be derived from the former. To that end
> move the packet intercept from an rx handler that is invoked by
> __netif_receive_skb_core to the ipv4 and ipv6 receive processing.
>
> IPv6 already saves the skb_iif to the control buffer in ipv6_rcv. Since
> the skb->dev has not been switched the cb has the enslaved device. Make
> the same happen for IPv4 by adding the skb_iif to inet_skb_parm and set
> it in ipv4 code after clearing the skb control buffer similar to IPv6.
>  From there the pktinfo can just pull it from cb with the PKTINFO_SKB_CB
> cast.
>
> David Ahern (2):
>    net: l3mdev: Add hook in ip and ipv6
>    net: original ingress device index in PKTINFO
>
>   drivers/net/vrf.c         | 186 ++++++++++++++++++++++------------------------
>   include/linux/ipv6.h      |   3 +-
>   include/linux/netdevice.h |   2 +
>   include/net/ip.h          |   1 +
>   include/net/l3mdev.h      |  43 +++++++++++
>   include/net/tcp.h         |   3 +-
>   net/core/dev.c            |   3 +-
>   net/ipv4/ip_input.c       |   8 ++
>   net/ipv4/ip_sockglue.c    |   7 +-
>   net/ipv6/ip6_input.c      |   7 ++
>   10 files changed, 161 insertions(+), 102 deletions(-)
>

Dave: please ignore. I have an update that better encapsulates the 
inet6_iif and tcp iif change. Will send v2 shortly.

      parent reply	other threads:[~2016-05-07  1:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-05 19:37 [PATCH net-next 0/2] net: vrf: Fixup PKTINFO to return enslaved device index David Ahern
2016-05-05 19:37 ` [PATCH net-next 1/2] net: l3mdev: Add hook in ip and ipv6 David Ahern
2016-05-05 19:37 ` [PATCH net-next 2/2] net: original ingress device index in PKTINFO David Ahern
2016-05-07  1:04 ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572D3F2F.4030307@cumulusnetworks.com \
    --to=dsa@cumulusnetworks$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox