From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: David Miller <davem@davemloft•net>,
Linux Kernel Network Developers <netdev@vger•kernel.org>
Subject: Re: [net-next PATCH v2 5/6] net sched: skbedit action fix late binding
Date: Mon, 9 May 2016 07:53:43 -0400 [thread overview]
Message-ID: <57307A47.9090307@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpXTTJjs0HBvRDzVY4eHVrGenq2bzkwCQo92vwWV0e9LUA@mail.gmail.com>
On 16-05-08 11:28 PM, Cong Wang wrote:
>> + /* if action exists and this is a late filter bind, no need
>> + * to continue processing
>> + */
>
> This comment looks useless, at least for me, because the code
> is already clear.
>
I will get rid of it. Note: I added it to one patch only incase
the feature of late binding was foreign to some people.
>
>> + if (aexists && bind)
>> + return 0;
>
>
> One extra tab?
>
thanks for catching it.
cheers,
jamal
next prev parent reply other threads:[~2016-05-09 11:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 17:26 [net-next PATCH v2 0/6] net sched: Fix broken late binding of actions Jamal Hadi Salim
2016-05-08 17:26 ` [net-next PATCH v2 1/6] net sched: vlan action fix late binding Jamal Hadi Salim
2016-05-09 3:08 ` Cong Wang
2016-05-09 11:50 ` Jamal Hadi Salim
2016-05-10 20:52 ` Jamal Hadi Salim
2016-05-08 17:26 ` [net-next PATCH v2 2/6] net sched: ipt " Jamal Hadi Salim
2016-05-08 17:26 ` [net-next PATCH v2 3/6] net sched: mirred " Jamal Hadi Salim
2016-05-09 3:19 ` Cong Wang
2016-05-09 11:51 ` Jamal Hadi Salim
2016-05-10 4:37 ` Cong Wang
2016-05-08 17:26 ` [net-next PATCH v2 4/6] net sched: simple " Jamal Hadi Salim
2016-05-08 17:26 ` [net-next PATCH v2 5/6] net sched: skbedit " Jamal Hadi Salim
2016-05-09 3:28 ` Cong Wang
2016-05-09 11:53 ` Jamal Hadi Salim [this message]
2016-05-08 17:26 ` [net-next PATCH v2 6/6] net sched: ife " Jamal Hadi Salim
2016-05-09 3:32 ` Cong Wang
2016-05-09 11:54 ` Jamal Hadi Salim
2016-05-08 17:29 ` [net-next PATCH v2 0/6] net sched: Fix broken late binding of actions Jamal Hadi Salim
2016-05-09 4:30 ` David Miller
2016-05-09 11:54 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57307A47.9090307@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox