From: Nicolas Dichtel <nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public•gmane.org>
To: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public•gmane.org,
drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH net-next v3] block/drbd: align properly u64 in nl messages
Date: Tue, 10 May 2016 11:09:53 +0200 [thread overview]
Message-ID: <5731A561.6090509@6wind.com> (raw)
In-Reply-To: <20160509131547.GX16459-w1SgEEioFePxa46PmUWvFg@public.gmane.org>
Le 09/05/2016 15:15, Lars Ellenberg a écrit :
> On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote:
[snip]
>> Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_'
>> could be interesting so that new module won't use it. What is your
>> opinion?
>
> This was supposed to not be DRBD specific. But it might even still
> need some massaging before it was truly generic. And obviously,
> it does not meet the taste of genetlink folks, to say the least :(
Yes, this file is not generic and netlink APIs are never defined like this.
These tons of macro complexifies the code too much. It's overengineering for
what purpose?
Small examples:
- the drbd netlink API is not exported via uapi (I wonder how apps using this
API get it)
- v2 of the patch is nacked because adding a new attribute may break existing
apps (in networking code, a lot of new attributes are added in each version)
- it's not possible to grep to show the definition of an attribute ('git grep
-w T_bits_total' returns only 1 line)
Regards,
Nicolas
next prev parent reply other threads:[~2016-05-10 9:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 8:06 [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 5/8] ovs: align nlattr properly when needed Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 6/8] rtnl: " Nicolas Dichtel
[not found] ` <1461657978-13360-1-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-04-26 8:06 ` [PATCH net-next 1/8] macsec: use nla_put_u64_64bit() Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 2/8] drivers/wireless: " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 3/8] fs/quota: " Nicolas Dichtel
[not found] ` <1461657978-13360-4-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-04-26 11:08 ` Jan Kara
[not found] ` <20160426110848.GD27612-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2016-04-26 12:31 ` Nicolas Dichtel
[not found] ` <571F5FBE.8050900-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-04-26 12:37 ` Jan Kara
2016-04-26 16:24 ` David Miller
2016-04-26 8:06 ` [PATCH net-next 4/8] sock_diag: align nlattr properly when needed Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 7/8] neigh: " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 8/8] sched: " Nicolas Dichtel
2016-04-26 11:54 ` [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) Lars Ellenberg
[not found] ` <20160426115427.GB20950-w1SgEEioFePxa46PmUWvFg@public.gmane.org>
2016-04-26 12:18 ` Lars Ellenberg
2016-05-03 8:50 ` [PATCH net-next] block/drbd: use nla_put_u64_64bit() Nicolas Dichtel
2016-05-03 9:28 ` Nicolas Dichtel
2016-05-03 9:39 ` [PATCH net-next v2] " Nicolas Dichtel
[not found] ` <1462268358-19044-1-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-05-03 10:06 ` Lars Ellenberg
2016-05-03 12:07 ` Nicolas Dichtel
2016-05-03 16:05 ` David Miller
[not found] ` <20160503.120556.1317913903199470646.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-05-04 9:05 ` Lars Ellenberg
2016-05-04 12:49 ` Nicolas Dichtel
[not found] ` <5729EFBC.7040002-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-05-04 12:52 ` Lars Ellenberg
2016-05-04 14:27 ` Eric Dumazet
2016-05-04 16:50 ` David Miller
2016-05-04 17:13 ` Eric Dumazet
2016-05-04 16:47 ` David Miller
2016-05-03 16:06 ` David Miller
2016-05-09 9:40 ` [PATCH net-next v3] block/drbd: align properly u64 in nl messages Nicolas Dichtel
[not found] ` <1462786820-15519-1-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-05-09 13:15 ` Lars Ellenberg
[not found] ` <20160509131547.GX16459-w1SgEEioFePxa46PmUWvFg@public.gmane.org>
2016-05-10 9:09 ` Nicolas Dichtel [this message]
[not found] ` <5731A561.6090509-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-05-10 9:40 ` Lars Ellenberg
2016-05-10 10:06 ` [Drbd-dev] " Nicolas Dichtel
2016-05-10 15:39 ` David Miller
[not found] ` <20160510.113949.2077250222547175741.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-05-10 19:09 ` Lars Ellenberg
2016-05-10 19:26 ` [Drbd-dev] " David Miller
2016-04-26 16:25 ` [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) David Miller
2016-04-26 16:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5731A561.6090509@6wind.com \
--to=nicolas.dichtel-pdr9zngts4eavxtiumwx3w@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox