From: Arend van Spriel <arend.vanspriel@broadcom•com>
To: "Rafał Miłecki" <zajec5@gmail•com>, "Kalle Valo" <kvalo@codeaurora•org>
Cc: Brett Rudley <brudley@broadcom•com>,
Arend van Spriel <arend@broadcom•com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom•com>,
Hante Meuleman <meuleman@broadcom•com>,
Pieter-Paul Giesberts <pieterpg@broadcom•com>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<linux-wireless@vger•kernel.org>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<brcm80211-dev-list@broadcom•com>,
"open list:NETWORKING DRIVERS" <netdev@vger•kernel.org>,
open list <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] brcmfmac: fix setting AP channel with new firmwares
Date: Wed, 25 May 2016 23:08:05 +0200 [thread overview]
Message-ID: <57461435.9080708@broadcom.com> (raw)
In-Reply-To: <1464080979-12150-1-git-send-email-zajec5@gmail.com>
On 24-05-16 11:09, Rafał Miłecki wrote:
> Firmware for new chipsets is based on a new major version of code
> internally maintained at Broadcom. E.g. brcmfmac4366b-pcie.bin (used for
> BCM4366B1) is based on 10.10.69.3309 while brcmfmac43602-pcie.ap.bin was
> based on 7.35.177.56.
>
> Currently setting AP 5 GHz channel doesn't work reliably with BCM4366B1.
> When setting e.g. 36 control channel with VHT80 (center channel 42)
> firmware may randomly pick one of:
> 1) 52 control channel with 58 as center one
> 2) 100 control channel with 106 as center one
> 3) 116 control channel with 122 as center one
> 4) 149 control channel with 155 as center one
>
> It seems new firmwares require setting AP mode (BRCMF_C_SET_AP) before
> specifying a channel. Changing an order of firmware calls fixes the
> problem.
>
> This fix was verified with BCM4366B1 and tested for regressions on
> BCM43602. It's unclear if it's needed (or correct at all) for P2P
> interfaces so it leaves this code unaffected.
In doing so the code reads a bit awkward so if P2P-GO works with the
changed order that would be preferable.
> Signed-off-by: Rafał Miłecki <zajec5@gmail•com>
> ---
> .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
next prev parent reply other threads:[~2016-05-25 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 9:09 [PATCH] brcmfmac: fix setting AP channel with new firmwares Rafał Miłecki
2016-05-25 21:08 ` Arend van Spriel [this message]
2016-05-25 21:49 ` Rafał Miłecki
2016-05-27 19:07 ` [PATCH V2] " Rafał Miłecki
2016-06-16 15:07 ` [V2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57461435.9080708@broadcom.com \
--to=arend.vanspriel@broadcom$(echo .)com \
--cc=arend@broadcom$(echo .)com \
--cc=brcm80211-dev-list@broadcom$(echo .)com \
--cc=brudley@broadcom$(echo .)com \
--cc=frankyl@broadcom$(echo .)com \
--cc=kvalo@codeaurora$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=meuleman@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pieterpg@broadcom$(echo .)com \
--cc=zajec5@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox