From: Edward Cree <ecree@solarflare•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: <linux-net-drivers@solarflare•com>, <davem@davemloft•net>,
<netdev@vger•kernel.org>
Subject: Re: [PATCH net 1/2] sfc: handle nonlinear SKBs in efx_filter_rfs()
Date: Thu, 26 May 2016 18:11:59 +0100 [thread overview]
Message-ID: <57472E5F.7020608@solarflare.com> (raw)
In-Reply-To: <1464281796.5939.96.camel@edumazet-glaptop3.roam.corp.google.com>
On 26/05/16 17:56, Eric Dumazet wrote:
> Lot of magic here. Yet another flow dissection.
>
> Seems to be a good place to use net/core/flow_dissector.c helpers.
Fair point, but that doesn't really feel like 'net' material.
I'll look into flow_dissector and see if I can get something ready for when net-next opens back up. But in the meantime I think this fix is still needed.
next prev parent reply other threads:[~2016-05-26 17:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 16:00 [PATCH net 0/2] sfc: aRFS fixes Edward Cree
2016-05-26 16:01 ` [PATCH net 1/2] sfc: handle nonlinear SKBs in efx_filter_rfs() Edward Cree
2016-05-26 16:56 ` Eric Dumazet
2016-05-26 17:11 ` Edward Cree [this message]
2016-05-26 19:47 ` David Miller
2016-05-26 20:46 ` [PATCH net] sfc: use flow dissector helpers for aRFS Edward Cree
2016-05-30 5:39 ` David Miller
2016-05-26 16:02 ` [PATCH net 2/2] sfc: Track RPS flow IDs per channel instead of per function Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57472E5F.7020608@solarflare.com \
--to=ecree@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox