Subject: Re: sel_netif_init: 'err' is used uninitialized (was: Re: selinux: reduce the number of calls to synchronize_net() when flushing caches)

From: Paul Moore <[email-masked]>
Date: Thu, 07 Aug 2014 10:26:14 -0400

On Thursday, August 07, 2014 12:31:15 PM Geert Uytterhoeven wrote:
> 
> security/selinux/netif.c: In function ‘sel_netif_init’:
> /scratch/geert/linux/linux-m68k/security/selinux/netif.c:285: warning:
> ‘err’ is used uninitialized in this function
> 
> Should it just return 0, like before?
> Or should it return the return value of register_netdevice_notifier()
> instead, which also returns an error code? Or is that failure non-critical?

Hi,

I posted a fix for this two days ago to the SELinux list (see below).  As soon 
as -rc1 is released and linux-next is back in business I'll be pushing the 
patch to the SELinux #next branch.

 * http://marc.info/?l=selinux&m=140727033030054&w=2

-- 
paul moore
www.paul-moore.com