Subject: Re: [PATCH v2 net] fq_codel: fix NET_XMIT_CN behavior

From: Jamal Hadi Salim <[email-masked]>
Date: Sun, 5 Jun 2016 09:03:10 -0400

On 16-06-04 03:55 PM, Eric Dumazet wrote:
> From: Eric Dumazet <[email-masked]>
>
> My prior attempt to fix the backlogs of parents failed.
>
> If we return NET_XMIT_CN, our parents wont increase their backlog,
> so our qdisc_tree_reduce_backlog() should take this into account.
>
> v2: Florian Westphal pointed out that we could drop the packet,
> so we need to save qdisc_pkt_len(skb) in a temp variable before
> calling fq_codel_drop()
>
> Fixes: 9d18562a2278 ("fq_codel: add batch ability to fq_codel_drop()")
> Fixes: 2ccccf5fb43f ("net_sched: update hierarchical backlog too")
> Reported-by: Stas Nichiporovich <[email-masked]>
> Signed-off-by: Eric Dumazet <[email-masked]>
> Cc: WANG Cong <[email-masked]>
> Cc: Jamal Hadi Salim <[email-masked]>

Acked-by: Jamal Hadi Salim <[email-masked]>

cheers,
jamal