From: Nikolay Aleksandrov via Bridge <bridge@lists•linux-foundation.org>
To: Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>,
"David S. Miller" <davem@davemloft•net>,
Stephen Hemminger <stephen@networkplumber•org>
Cc: netdev@vger•kernel.org, bridge@lists•linux-foundation.org
Subject: Re: [PATCH net] bridge: Don't insert unnecessary local fdb entry on changing mac address
Date: Tue, 7 Jun 2016 13:13:23 +0200 [thread overview]
Message-ID: <5756AC53.70406@cumulusnetworks.com> (raw)
In-Reply-To: <1465294457-2785-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
On 06/07/2016 12:14 PM, Toshiaki Makita wrote:
> The missing br_vlan_should_use() test caused creation of an unneeded
> local fdb entry on changing mac address of a bridge device when there is
> a vlan which is configured on a bridge port but not on the bridge
> device.
>
> Fixes: 2594e9064a57 ("bridge: vlan: add per-vlan struct and move to rhashtables")
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>
> ---
Good catch,
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
next prev parent reply other threads:[~2016-06-07 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 10:14 [PATCH net] bridge: Don't insert unnecessary local fdb entry on changing mac address Toshiaki Makita
2016-06-07 11:13 ` Nikolay Aleksandrov via Bridge [this message]
2016-06-08 7:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756AC53.70406@cumulusnetworks.com \
--to=bridge@lists$(echo .)linux-foundation.org \
--cc=davem@davemloft$(echo .)net \
--cc=makita.toshiaki@lab$(echo .)ntt.co.jp \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox