From: Daniel Borkmann <daniel@iogearbox•net>
To: Ben Dooks <ben.dooks@codethink•co.uk>,
linux-kernel@lists•codethink.co.uk
Cc: "David S. Miller" <davem@davemloft•net>,
Alexey Kuznetsov <kuznet@ms2•inr.ac.ru>,
James Morris <jmorris@namei•org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
Patrick McHardy <kaber@trash•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH] net: ipconfgi: add declaration for ic_addrservaddr
Date: Thu, 09 Jun 2016 13:35:05 +0200 [thread overview]
Message-ID: <57595469.7010708@iogearbox.net> (raw)
In-Reply-To: <1465470466-11379-1-git-send-email-ben.dooks@codethink.co.uk>
On 06/09/2016 01:07 PM, Ben Dooks wrote:
> The symbol ic_addrservaddr is not static, but has no declaration
> to match. Since the similar variables are all exported, add this
> one to the header file as well.
>
> This fixes the following warning:
>
> net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink•co.uk>
Well, how about making it actually static if it's only used
from ipconfig.c ?
next prev parent reply other threads:[~2016-06-09 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 11:07 [PATCH] net: ipconfgi: add declaration for ic_addrservaddr Ben Dooks
2016-06-09 11:35 ` Daniel Borkmann [this message]
2016-06-09 12:11 ` Ben Dooks
2016-06-09 12:15 ` Daniel Borkmann
2016-06-09 18:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57595469.7010708@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=ben.dooks@codethink$(echo .)co.uk \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-kernel@lists$(echo .)codethink.co.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox