Subject: Re: [PATCHv3 net-next 04/12] ndisc: add __ndisc_opt_addr_space function

From: Stefan Schmidt <[email-masked]>
Date: Wed, 15 Jun 2016 17:09:33 +0200

Hello.

On 14/06/16 13:52, Alexander Aring wrote:
> This patch adds __ndisc_opt_addr_space as low-level function for
> ndisc_opt_addr_space which doesn't depend on net_device parameter.
>
> Cc: David S. Miller<davem-fT/PcQaiUtIeIZ0/[email-masked]>
> Cc: Alexey Kuznetsov<kuznet-v/[email-masked]>
> Cc: James Morris<jmorris-gx6/[email-masked]>
> Cc: Hideaki YOSHIFUJI<[email-masked]>
> Cc: Patrick McHardy<[email-masked]>
> Signed-off-by: Alexander Aring<[email-masked]>
> ---
>   include/net/ndisc.h | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/include/net/ndisc.h b/include/net/ndisc.h
> index 2d8edaa..4cee826 100644
> --- a/include/net/ndisc.h
> +++ b/include/net/ndisc.h
> @@ -127,10 +127,15 @@ static inline int ndisc_addr_option_pad(unsigned short type)
>   	}
>   }
>   
> +static inline int __ndisc_opt_addr_space(unsigned char addr_len, int pad)
> +{
> +	return NDISC_OPT_SPACE(addr_len + pad);
> +}
> +
>   static inline int ndisc_opt_addr_space(struct net_device *dev)
>   {
> -	return NDISC_OPT_SPACE(dev->addr_len +
> -			       ndisc_addr_option_pad(dev->type));
> +	return __ndisc_opt_addr_space(dev->addr_len,
> +				      ndisc_addr_option_pad(dev->type));
>   }
>   
>   static inline u8 *ndisc_opt_addr_data(struct nd_opt_hdr *p,

Reviewed-by: Stefan Schmidt<[email-masked]>

regards
Stefan Schmidt