Subject: Re: [Patch net 1/2] act_ife: only acquire tcf_lock for existing actions

From: Jamal Hadi Salim <[email-masked]>
Date: Thu, 23 Jun 2016 07:10:29 -0400

On 16-06-20 04:37 PM, Cong Wang wrote:
> Alexey reported that we have GFP_KERNEL allocation when
> holding the spinlock tcf_lock. Actually we don't have
> to take that spinlock for all the cases, especially
> for the new one we just create. To modify the existing
> actions, we still need this spinlock to make sure
> the whole update is atomic.
>
> For net-next, we can get rid of this spinlock because
> we already hold the RTNL lock on slow path, and on fast
> path we can use RCU to protect the metalist.
>
> Joint work with Jamal.
>
> Reported-by: Alexey Khoroshilov <[email-masked]>
> Cc: Jamal Hadi Salim <[email-masked]>
> Signed-off-by: Cong Wang <[email-masked]>

Acked-by: Jamal Hadi Salim <[email-masked]>

cheers,
jamal