From: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
To: Eric Dumazet <eric.dumazet@gmail•com>,
David Miller <davem@davemloft•net>
Cc: netdev <netdev@vger•kernel.org>,
Mahesh Bandewar <maheshb@google•com>,
Nikolay Aleksandrov <nikolay@redhat•com>,
Ding Tianhong <dingtianhong@huawei•com>,
Dmitry Vyukov <dvyukov@google•com>
Subject: Re: [PATCH net] bonding: prevent out of bound accesses
Date: Thu, 30 Jun 2016 15:24:59 +0200 [thread overview]
Message-ID: <57751DAB.9080900@cumulusnetworks.com> (raw)
In-Reply-To: <1467291379.11238.8.camel@edumazet-glaptop3.roam.corp.google.com>
On 30/06/16 14:56, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google•com>
>
> ether_addr_equal_64bits() requires some care about its arguments,
> namely that 8 bytes might be read, even if last 2 byte values are not
> used.
>
> KASan detected a violation with null_mac_addr and lacpdu_mcast_addr
> in bond_3ad.c
>
> Fixes: 815117adaf5b ("bonding: use ether_addr_equal_unaligned for bond addr compare")
> Fixes: bb54e58929f3 ("bonding: Verify RX LACPDU has proper dest mac-addr")
> Signed-off-by: Eric Dumazet <edumazet@google•com>
> Reported-by: Dmitry Vyukov <dvyukov@google•com>
> ---
> drivers/net/bonding/bond_3ad.c | 11 +++++++----
> drivers/net/bonding/bond_alb.c | 3 ---
> include/net/bonding.h | 7 ++++++-
> 3 files changed, 13 insertions(+), 8 deletions(-)
>
Good catch,
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
next prev parent reply other threads:[~2016-06-30 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 12:56 [PATCH net] bonding: prevent out of bound accesses Eric Dumazet
2016-06-30 13:04 ` Dmitry Vyukov
2016-06-30 13:25 ` Eric Dumazet
2016-06-30 13:35 ` Dmitry Vyukov
2016-06-30 14:08 ` Eric Dumazet
2016-06-30 14:13 ` Dmitry Vyukov
2016-06-30 13:24 ` Nikolay Aleksandrov [this message]
2016-06-30 14:13 ` [PATCH v2 " Eric Dumazet
2016-06-30 14:19 ` Dmitry Vyukov
2016-06-30 14:43 ` Nikolay Aleksandrov
2016-07-01 1:09 ` Ding Tianhong
2016-07-01 10:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57751DAB.9080900@cumulusnetworks.com \
--to=nikolay@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dingtianhong@huawei$(echo .)com \
--cc=dvyukov@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=maheshb@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox