Subject: Re: [PATCH 1/1] qlcnic: add wmb() call in transmit data path.

From: Lino Sanfilippo <[email-masked]>
Date: Thu, 30 Jun 2016 17:41:47 +0200

On 30.06.2016 17:32, Lino Sanfilippo wrote:
> Hi,
>
> On 29.06.2016 23:51, Sony Chacko wrote:
>
>> +    /* Ensure writes are complete before HW fetches Tx descriptors */
>> +    wmb();
>>       qlcnic_update_cmd_producer(tx_ring);
>>
>>       return NETDEV_TX_OK;
>>
>
> Would not an mmiowb be more appropriate in this case?
>
> Regards,
> Lino

Sorry, this was nonsense. This should be "dma_wmb" not "mmiowb".

Regards,
Lino