From: Jamal Hadi Salim <jhs@mojatatu•com>
To: John Fastabend <john.fastabend@gmail•com>, brouer@redhat•com
Cc: netdev@vger•kernel.org
Subject: Re: [net-next PATCH 1/2] net: pktgen: support injecting packets for qdisc testing
Date: Fri, 1 Jul 2016 08:56:11 -0400 [thread overview]
Message-ID: <5776686B.5090204@mojatatu.com> (raw)
In-Reply-To: <57754E6E.8010602@gmail.com>
On 16-06-30 12:53 PM, John Fastabend wrote:
> On 16-06-30 03:21 AM, Jamal Hadi Salim wrote:
>> On 16-06-29 03:47 PM, John Fastabend wrote:
>
> Taking a look at the link couple differences exist. First the patch
> linked does a 'netif_xmit_frozen_or_drv_stopped(txq)' check but this
> really shouldn't be needed it is handled by the sch_direct_xmit()
> logic in ./net/sched
>
> Also in this patch I made it way more conservative on when to back
> off then my original patch and now its closer to the one linked except
> I also back off with return code NET_XMIT_CN.
>
> As for clones what is the concern exactly? We allow them through the
> ingress pktgen mode that can hit classifiers and I don't see any issues
> testing with them.
>
I sent you that because we discussed back then and you thought
there was something different and useful.
I dont remember why it was important to avoid clones - maybe i had a
bug. I thought we discussed it (I will try to dig into the machine
used for testing).
Anyways, doesnt matter if you tested and it works fine.
cheers,
jamal
next prev parent reply other threads:[~2016-07-01 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 19:47 [net-next PATCH 1/2] net: pktgen: support injecting packets for qdisc testing John Fastabend
2016-06-29 19:47 ` [net-next PATCH 2/2] net: samples: pktgen mode samples/tests for qdisc layer John Fastabend
2016-06-30 10:21 ` [net-next PATCH 1/2] net: pktgen: support injecting packets for qdisc testing Jamal Hadi Salim
2016-06-30 16:53 ` John Fastabend
2016-07-01 12:56 ` Jamal Hadi Salim [this message]
2016-07-02 21:12 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5776686B.5090204@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=brouer@redhat$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox