Subject: Re: [PATCH] net: check for NULL net_device in FIB tables

From: Vegard Nossum <[email-masked]>
Date: Mon, 4 Jul 2016 15:50:23 +0200

On 07/04/2016 02:47 PM, Vegard Nossum wrote:
> struct fib_nh->nh_dev can be NULL, so we should check it before calling
> __in_dev_get_rcu on it.

That should say __in_dev_get_rtnl(), obviously.

>
> Multiple places seem to want this (and check the return value), so we can
> add a convenience wrapper for this.
>
> This fixes a crash in AF_NETLINK sendmsg().
>
> Please double check that I caught all the callers that need the NULL
> guard.
>
> Fixes: 0eeb075fad73 ("net: ipv4 sysctl option to ignore routes when nexthop link is down")
> Cc: Andy Gospodarek <[email-masked]>
> Cc: Dinesh Dutt <[email-masked]>
> Cc: Scott Feldman <[email-masked]>
> Cc: David S. Miller <[email-masked]>
> Signed-off-by: Vegard Nossum <[email-masked]>

I guess we could also add:

Cc: [email-masked]

Vegard