From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Vegard Nossum <vegard.nossum@oracle•com>,
Steffen Klassert <steffen.klassert@secunet•com>,
Herbert Xu <herbert@gondor•apana.org.au>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH] xfrm: fix crash in XFRM_MSG_GETSA netlink handler
Date: Tue, 5 Jul 2016 12:14:12 +0200 [thread overview]
Message-ID: <577B8874.5060904@6wind.com> (raw)
In-Reply-To: <1467706688-3631-1-git-send-email-vegard.nossum@oracle.com>
Le 05/07/2016 10:18, Vegard Nossum a écrit :
> If we hit any of the error conditions inside xfrm_dump_sa(), then
> xfrm_state_walk_init() never gets called. However, we still call
> xfrm_state_walk_done() from xfrm_dump_sa_done(), which will crash
> because the state walk was never initialized properly.
>
> We can fix this by setting cb->args[0] only after we've processed the
> first element and checking this before calling xfrm_state_walk_done().
>
> Fixes: d3623099d3 ("ipsec: add support of limited SA dump")
> Cc: Nicolas Dichtel <nicolas.dichtel@6wind•com>
> Cc: Steffen Klassert <steffen.klassert@secunet•com>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle•com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
Thank you for the fix!
next prev parent reply other threads:[~2016-07-05 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 8:18 [PATCH] xfrm: fix crash in XFRM_MSG_GETSA netlink handler Vegard Nossum
2016-07-05 10:14 ` Nicolas Dichtel [this message]
2016-07-05 19:13 ` David Miller
2016-07-06 2:27 ` Herbert Xu
2016-07-10 12:21 ` Steffen Klassert
2016-07-19 7:35 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577B8874.5060904@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=vegard.nossum@oracle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox