From: Florian Fainelli <f.fainelli@gmail•com>
To: Linus Walleij <linus.walleij@linaro•org>,
netdev@vger•kernel.org, "David S . Miller" <davem@davemloft•net>,
Steve Glendinning <steve.glendinning@smsc•com>
Cc: Guenter Roeck <linux@roeck-us•net>,
Jeremy Linton <jeremy.linton@arm•com>,
Kamlakant Patel <kamlakant.patel@broadcom•com>,
Pavel Fedin <p.fedin@samsung•com>,
Sudeep Holla <sudeep.holla@arm•com>,
Alexandre Belloni <alexandre.belloni@free-electrons•com>,
Tony Lindgren <tony@atomide•com>,
"Rafael J . Wysocki" <rjw@rjwysocki•net>,
John Stultz <john.stultz@linaro•org>
Subject: Re: [PATCH 3/3] RFC: net: smsc911x: add wake-up event interrupt support
Date: Fri, 15 Jul 2016 12:13:34 -0700 [thread overview]
Message-ID: <578935DE.8090104@gmail.com> (raw)
In-Reply-To: <1467968852-6175-3-git-send-email-linus.walleij@linaro.org>
On 07/08/2016 02:07 AM, Linus Walleij wrote:
> +static irqreturn_t smsc911x_pme_irq_thread(int irq, void *dev_id)
> +{
> + struct net_device *dev = dev_id;
> + struct smsc911x_data *pdata __maybe_unused = netdev_priv(dev);
> +
> + SMSC_TRACE(pdata, pm, "wakeup event");
> + /* This signal is active for 50 ms, wait for it to deassert */
> + usleep_range(50000, 100000);
Should not you have a call to pm_wakeup_event() such that this probably
gets accounted for as a wake-up event in /sys/*?
--
Florian
next prev parent reply other threads:[~2016-07-15 19:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 9:07 [PATCH 1/3] net: smsc911x: augment device tree bindings Linus Walleij
2016-07-08 9:07 ` [PATCH 2/3] net: smsc911x: request and deassert optional RESET GPIO Linus Walleij
2016-07-08 13:52 ` Guenter Roeck
2016-07-08 9:07 ` [PATCH 3/3] RFC: net: smsc911x: add wake-up event interrupt support Linus Walleij
2016-07-11 8:14 ` Tony Lindgren
2016-07-11 10:23 ` Sudeep Holla
2016-07-15 19:13 ` Florian Fainelli [this message]
2016-07-15 19:03 ` [PATCH 1/3] net: smsc911x: augment device tree bindings Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578935DE.8090104@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=alexandre.belloni@free-electrons$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jeremy.linton@arm$(echo .)com \
--cc=john.stultz@linaro$(echo .)org \
--cc=kamlakant.patel@broadcom$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux@roeck-us$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=p.fedin@samsung$(echo .)com \
--cc=rjw@rjwysocki$(echo .)net \
--cc=steve.glendinning@smsc$(echo .)com \
--cc=sudeep.holla@arm$(echo .)com \
--cc=tony@atomide$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox