From: David Daney <ddaney@caviumnetworks•com>
To: Peter Chen <peter.chen@nxp•com>
Cc: <davem@davemloft•net>, <netdev@vger•kernel.org>,
<vbridger@opensource•altera.com>, <isubramanian@apm•com>,
<kchudgar@apm•com>, <yisen.zhuang@huawei•com>,
<salil.mehta@huawei•com>, <thomas.petazzoni@free-electrons•com>,
<sergei.shtylyov@cogentembedded•com>, <peppe.cavallaro@st•com>,
<alexandre.torgue@st•com>, <mugunthanvnm@ti•com>,
<tremyfr@gmail•com>, <wxt@rock-chips•com>, <arnd@arndb•de>,
<david.daney@cavium•com>, <huangdaode@hisilicon•com>,
<jszhang@marvell•com>
Subject: Re: [PATCH 05/15] ethernet: cavium: octeon: add missing of_node_put after calling of_parse_phandle
Date: Wed, 27 Jul 2016 13:56:16 -0700 [thread overview]
Message-ID: <57991FF0.1010606@caviumnetworks.com> (raw)
In-Reply-To: <1469586048-15697-6-git-send-email-peter.chen@nxp.com>
On 07/26/2016 07:20 PM, Peter Chen wrote:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Signed-off-by: Peter Chen <peter.chen@nxp•com>
NAK.
> ---
> drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
> index e8bc15b..5eb9d8c 100644
> --- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
> +++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
> @@ -960,6 +960,7 @@ static int octeon_mgmt_init_phy(struct net_device *netdev)
> phydev = of_phy_connect(netdev, p->phy_np,
> octeon_mgmt_adjust_link, 0,
> PHY_INTERFACE_MODE_MII);
> + of_node_put(p->phy_np);
I don't think you can do this here. octeon_mgmt_init_phy() may be
called multiple times in the life of the driver, so p->phy_np must
remain valid.
It may be appropriate to do the of_node_put() in the
octeon_mgmt_remove() function.
>
> if (!phydev)
> return -ENODEV;
>
next prev parent reply other threads:[~2016-07-27 21:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 2:20 [PATCH 00/15] ethernet: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-27 2:20 ` [PATCH 01/15] ethernet: altera: add missing of_node_put Peter Chen
2016-07-27 2:20 ` [PATCH 02/15] ethernet: apm: xgene: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-27 2:20 ` [PATCH 03/15] ethernet: arc: emac_main: " Peter Chen
2016-07-27 2:20 ` [PATCH 04/15] ethernet: aurora: nb8800: " Peter Chen
2016-07-30 6:13 ` David Miller
2016-08-01 1:19 ` Peter Chen
2016-07-27 2:20 ` [PATCH 05/15] ethernet: cavium: octeon: " Peter Chen
2016-07-27 20:56 ` David Daney [this message]
2016-07-28 1:57 ` Peter Chen
2016-07-27 2:20 ` [PATCH 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: " Peter Chen
2016-07-28 0:38 ` Yisen Zhuang
2016-07-28 3:43 ` Peter Chen
2016-07-27 2:20 ` [PATCH 07/15] ethernet: hisilicon: hns: hns_dsaf_main: " Peter Chen
2016-07-27 2:20 ` [PATCH 08/15] ethernet: marvell: mvneta: " Peter Chen
2016-07-27 2:20 ` [PATCH 09/15] ethernet: marvell: mvpp2: " Peter Chen
2016-07-27 2:20 ` [PATCH 10/15] ethernet: marvell: pxa168_eth: " Peter Chen
2016-07-27 2:20 ` [PATCH 11/15] ethernet: renesas: ravb_main: " Peter Chen
2016-07-27 10:50 ` Sergei Shtylyov
2016-07-27 2:20 ` [PATCH 12/15] ethernet: renesas: sh_eth: " Peter Chen
2016-07-27 10:51 ` Sergei Shtylyov
2016-07-27 2:20 ` [PATCH 13/15] ethernet: stmicro: stmmac: dwmac-socfpga: " Peter Chen
2016-07-27 2:20 ` [PATCH 14/15] ethernet: stmicro: stmmac: stmmac_platform: " Peter Chen
2016-07-28 7:39 ` Alexandre Torgue
2016-07-28 9:30 ` Peter Chen
2016-08-01 6:50 ` Peter Chen
2016-07-27 2:20 ` [PATCH 15/15] ethernet: ti: davinci_emac: " Peter Chen
2016-07-27 5:45 ` Mugunthan V N
2016-07-27 7:43 ` Peter Chen
2016-07-29 9:29 ` Mugunthan V N
2016-08-01 1:21 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57991FF0.1010606@caviumnetworks.com \
--to=ddaney@caviumnetworks$(echo .)com \
--cc=alexandre.torgue@st$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=david.daney@cavium$(echo .)com \
--cc=huangdaode@hisilicon$(echo .)com \
--cc=isubramanian@apm$(echo .)com \
--cc=jszhang@marvell$(echo .)com \
--cc=kchudgar@apm$(echo .)com \
--cc=mugunthanvnm@ti$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=peter.chen@nxp$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
--cc=tremyfr@gmail$(echo .)com \
--cc=vbridger@opensource$(echo .)altera.com \
--cc=wxt@rock-chips$(echo .)com \
--cc=yisen.zhuang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox