From: Dongpo Li <lidongpo-C8/M+/jPZTeaMJb+Lgu22Q@public•gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public•gmane.org>,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public•gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public•gmane.org>,
Zhangfei Gao
<zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org>,
Yisen Zhuang
<yisen.zhuang-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<salil.mehta-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public•gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public•gmane.org>,
<xuejiancheng-C8/M+/jPZTeaMJb+Lgu22Q@public•gmane.org>,
<benjamin.chenhao-C8/M+/jPZTeaMJb+Lgu22Q@public•gmane.org>,
<howell.yang-C8/M+/jPZTeaMJb+Lgu22Q@public•gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
linux-clk <linux-clk-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: [PATCH 1/4] net: hix5hd2_gmac: add tx scatter-gather feature
Date: Tue, 16 Aug 2016 10:28:12 +0800 [thread overview]
Message-ID: <57B27A3C.5070403@hisilicon.com> (raw)
In-Reply-To: <CAL_JsqLgzaPECHdX8yHC3DAUq0jXhgUFE+xVFbeV0OLQXopqxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 2016/8/16 0:18, Rob Herring wrote:
> On Mon, Aug 15, 2016 at 1:50 AM, Dongpo Li <lidongpo-C8/M+/jPZTeaMJb+Lgu22Q@public•gmane.org> wrote:
>> Hi Rob,
>> Many thanks for your review.
>>
>> On 2016/8/13 2:43, Rob Herring wrote:
>>> On Thu, Aug 11, 2016 at 05:01:52PM +0800, Dongpo Li wrote:
>>>> From: Li Dongpo <lidongpo-C8/M+/jPZTeaMJb+Lgu22Q@public•gmane.org>
>>>>
>>>> The "hix5hd2" is SoC name, add the generic ethernet driver name.
>>>> The "hisi-gemac-v1" is the basic version and "hisi-gemac-v2" adds
>>>> the SG/TXCSUM/TSO/UFO features.
>>>> This patch only adds the SG(scatter-gather) driver for transmitting,
>>>> the drivers of other features will be submitted later.
>>>
>>> The compatible string changes should probably be a separate patch.
>>>
>> ok, I will split this patch into two patches, one for compatible string changes,
>> and one for driver feature implementation.
>>
>>>> Signed-off-by: Dongpo Li <lidongpo-C8/M+/jPZTeaMJb+Lgu22Q@public•gmane.org>
>>>> ---
>>>> .../bindings/net/hisilicon-hix5hd2-gmac.txt | 9 +-
>>>> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 213 +++++++++++++++++++--
>>>> 2 files changed, 205 insertions(+), 17 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt b/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt
>>>> index 75d398b..3c02fac 100644
>>>> --- a/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt
>>>> +++ b/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt
>>>> @@ -1,7 +1,12 @@
>>>> Hisilicon hix5hd2 gmac controller
>>>>
>>>> Required properties:
>>>> -- compatible: should be "hisilicon,hix5hd2-gmac".
>>>> +- compatible: should contain one of the following version strings:
>>>> + * "hisilicon,hisi-gemac-v1"
>>>> + * "hisilicon,hisi-gemac-v2"
>>>> + and one of the following SoC string:
>>>> + * "hisilicon,hix5hd2-gemac"
>>>> + * "hisilicon,hi3798cv200-gemac"
>>>
>>> Make it clear what the order should be.
>>>
>> ok, I will put the SoC strings in alphabetical order.
>
> No, I mean the most specific string comes first.
>
ok, I will fix it in next patch version. Thank you.
> Rob
>
> .
>
Regards,
Dongpo
.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-16 2:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 9:01 [PATCH 0/4] net: hix5hd2_gmac: add tx sg feature and reset/clock control signals Dongpo Li
[not found] ` <1470906115-155569-1-git-send-email-lidongpo-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2016-08-11 9:01 ` [PATCH 1/4] net: hix5hd2_gmac: add tx scatter-gather feature Dongpo Li
2016-08-12 18:43 ` Rob Herring
2016-08-15 6:50 ` Dongpo Li
2016-08-15 16:18 ` Rob Herring
[not found] ` <CAL_JsqLgzaPECHdX8yHC3DAUq0jXhgUFE+xVFbeV0OLQXopqxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-16 2:28 ` Dongpo Li [this message]
2016-08-11 9:01 ` [PATCH 2/4] net: hix5hd2_gmac: add reset control and clock signals Dongpo Li
[not found] ` <1470906115-155569-3-git-send-email-lidongpo-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2016-08-12 18:48 ` Rob Herring
2016-08-15 7:07 ` Dongpo Li
2016-08-11 9:01 ` [PATCH 3/4] clk: hix5hd2: change ethernet clock type Dongpo Li
[not found] ` <1470906115-155569-4-git-send-email-lidongpo-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2016-08-11 12:09 ` kbuild test robot
[not found] ` <201608112002.qeCiGZLQ%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-15 7:49 ` Dongpo Li
2016-08-11 9:01 ` [PATCH 4/4] ARM: dts: hix5hd2: add gmac clock and reset property Dongpo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B27A3C.5070403@hisilicon.com \
--to=lidongpo-c8/m+/jpzteamjb+lgu22q@public$(echo .)gmane.org \
--cc=andrew-g2DYL2Zd6BY@public$(echo .)gmane.org \
--cc=arnd-r2nGTMty4D4@public$(echo .)gmane.org \
--cc=benjamin.chenhao-C8/M+/jPZTeaMJb+Lgu22Q@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=howell.yang-C8/M+/jPZTeaMJb+Lgu22Q@public$(echo .)gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public$(echo .)gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public$(echo .)gmane.org \
--cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public$(echo .)gmane.org \
--cc=salil.mehta-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public$(echo .)gmane.org \
--cc=xuejiancheng-C8/M+/jPZTeaMJb+Lgu22Q@public$(echo .)gmane.org \
--cc=yisen.zhuang-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox