From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Rami Rosen <rami.rosen@intel•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org,
eric.dumazet@gmail•com, wkok@cumulusnetworks•com
Subject: Re: [PATCH net-next] switchdev: Fix return value of switchdev_port_fdb_dump().
Date: Fri, 02 Sep 2016 06:11:38 -0700 [thread overview]
Message-ID: <57C97A8A.2090203@cumulusnetworks.com> (raw)
In-Reply-To: <1472814717-11339-1-git-send-email-rami.rosen@intel.com>
On 9/2/16, 4:11 AM, Rami Rosen wrote:
> This patch fixes the retun value of switchdev_port_fdb_dump() when
> CONFIG_NET_SWITCHDEV is not set. This avoids getting "warning: return makes
> integer from pointer without a cast [-Wint-conversion]" when building
> when CONFIG_NET_SWITCHDEV is not set under several compiler versions.
> This warning is due to commit d297653dd6f07afbe7e6c702a4bcd7615680002e
> ("rtnetlink: fdb dump: optimize by saving last interface markers").
>
> Signed-off-by: Rami Rosen <rami.rosen@intel•com>
> ---
Acked-by: Roopa Prabhu <roopa@cumulusnetworks•com>
Thanks Rami.
> include/net/switchdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index 6279f2f..729fe15 100644
> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -344,7 +344,7 @@ static inline int switchdev_port_fdb_dump(struct sk_buff *skb,
> struct net_device *filter_dev,
> int *idx)
> {
> - return idx;
> + return *idx;
> }
>
> static inline bool switchdev_port_same_parent_id(struct net_device *a,
next prev parent reply other threads:[~2016-09-02 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 11:11 [PATCH net-next] switchdev: Fix return value of switchdev_port_fdb_dump() Rami Rosen
2016-09-02 13:11 ` Roopa Prabhu [this message]
2016-09-02 13:48 ` Eric Dumazet
2016-09-02 18:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C97A8A.2090203@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rami.rosen@intel$(echo .)com \
--cc=wkok@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox