public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: netdev@vger•kernel.org, davem@davemloft•net, nogahf@mellanox•com,
	idosch@mellanox•com, eladr@mellanox•com, yotamg@mellanox•com,
	ogerlitz@mellanox•com, nikolay@cumulusnetworks•com,
	linville@tuxdriver•com, tgraf@suug•ch, gospo@cumulusnetworks•com,
	sfeldma@gmail•com, sd@queasysnail•net, eranbe@mellanox•com,
	ast@plumgrid•com, edumazet@google•com,
	hannes@stressinduktion•org, f.fainelli@gmail•com,
	dsa@cumulusnetworks•com
Subject: Re: [patch net-next v8 0/3] return offloaded stats as default and expose original sw stats
Date: Thu, 08 Sep 2016 19:21:30 -0700	[thread overview]
Message-ID: <57D21CAA.7090605@cumulusnetworks.com> (raw)
In-Reply-To: <1473315593-2078-1-git-send-email-jiri@resnulli.us>

On 9/7/16, 11:19 PM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox•com>
>
> The problem we try to handle is about offloaded forwarded packets
> which are not seen by kernel. Let me try to draw it:
>
>     port1                       port2 (HW stats are counted here)
>       \                          /
>        \                        /
>         \                      /
>          --(A)---- ASIC --(B)--
>                     |
>                    (C)
>                     |
>                    CPU (SW stats are counted here)
>
>
> Now we have couple of flows for TX and RX (direction does not matter here):
>
> 1) port1->A->ASIC->C->CPU
>
>    For this flow, HW and SW stats are equal.
>
> 2) port1->A->ASIC->C->CPU->C->ASIC->B->port2
>
>    For this flow, HW and SW stats are equal.
>
> 3) port1->A->ASIC->B->port2
>
>    For this flow, SW stats are 0.
>
> The purpose of this patchset is to provide facility for user to
> find out the difference between flows 1+2 and 3. In other words, user
> will be able to see the statistics for the slow-path (through kernel).
>
> Also note that HW stats are what someone calls "accumulated" stats.
> Every packet counted by SW is also counted by HW. Not the other way around.
>
> As a default the accumulated stats (HW) will be exposed to user
> so the userspace apps can react properly.
>
> This patchset add the SW stats (flows 1+2) under offload related stats, so
> in the future we can expose other offload related stat in a similar way.
>

Acked-by: Roopa Prabhu <roopa@cumulusnetworks•com>

thanks.

      parent reply	other threads:[~2016-09-09  2:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08  6:19 [patch net-next v8 0/3] return offloaded stats as default and expose original sw stats Jiri Pirko
2016-09-08  6:19 ` [patch net-next v8 1/3] netdevice: Add offload statistics ndo Jiri Pirko
2016-09-08  6:19 ` [patch net-next v8 2/3] net: core: Add offload stats to if_stats_msg Jiri Pirko
2016-09-09 13:23   ` Nikolay Aleksandrov
2016-09-09 13:36   ` Nikolay Aleksandrov
2016-09-09 13:39     ` Nikolay Aleksandrov
2016-09-12 11:29       ` Nogah Frankel
2016-09-08  6:19 ` [patch net-next v8 3/3] mlxsw: spectrum: Implement offload stats ndo and expose HW stats by default Jiri Pirko
2016-09-09  2:21 ` Roopa Prabhu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57D21CAA.7090605@cumulusnetworks.com \
    --to=roopa@cumulusnetworks$(echo .)com \
    --cc=ast@plumgrid$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=dsa@cumulusnetworks$(echo .)com \
    --cc=edumazet@google$(echo .)com \
    --cc=eladr@mellanox$(echo .)com \
    --cc=eranbe@mellanox$(echo .)com \
    --cc=f.fainelli@gmail$(echo .)com \
    --cc=gospo@cumulusnetworks$(echo .)com \
    --cc=hannes@stressinduktion$(echo .)org \
    --cc=idosch@mellanox$(echo .)com \
    --cc=jiri@resnulli$(echo .)us \
    --cc=linville@tuxdriver$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=nikolay@cumulusnetworks$(echo .)com \
    --cc=nogahf@mellanox$(echo .)com \
    --cc=ogerlitz@mellanox$(echo .)com \
    --cc=sd@queasysnail$(echo .)net \
    --cc=sfeldma@gmail$(echo .)com \
    --cc=tgraf@suug$(echo .)ch \
    --cc=yotamg@mellanox$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox