From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: David Miller <davem@davemloft•net>
Cc: stephen@networkplumber•org, netdev@vger•kernel.org
Subject: Re: [PATCH net-next] rtnetlink: remove unused ifla_stats_policy
Date: Thu, 08 Sep 2016 19:56:47 -0700 [thread overview]
Message-ID: <57D224EF.10009@cumulusnetworks.com> (raw)
In-Reply-To: <20160908.172319.506563196312084552.davem@davemloft.net>
On 9/8/16, 5:23 PM, David Miller wrote:
> From: Stephen Hemminger <stephen@networkplumber•org>
> Date: Wed, 7 Sep 2016 13:57:36 -0700
>
>> This structure is defined but never used. Flagged with W=1
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber•org>
> This comes from commit 10c9ead9f3c6bb24bddc9a96681f7d58e6623966
> ("rtnetlink: add new RTM_GETSTATS message to dump link stats")
>
> Roopa, did you intentionally put this here unreferenced for the
> purposes or documentation or something like that?
I went back and looked at all my submissions to remember why i had it.
I don't seem to have used it anywhere...but i had expressed an intent to use
it to parse filter attributes in incoming stats requests in my first few versions.
I possibly just forgot to drop it after i moved to a mask to filter incoming stats requests.
thanks for checking...
Acked-by: Roopa Prabhu <roopa@cumulusnetworks•com>
and thanks stephen for cleaning this up.
next prev parent reply other threads:[~2016-09-09 2:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 20:57 [PATCH net-next] rtnetlink: remove unused ifla_stats_policy Stephen Hemminger
2016-09-09 0:23 ` David Miller
2016-09-09 2:56 ` Roopa Prabhu [this message]
2016-09-09 23:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D224EF.10009@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox