Subject: Re: [PATCH net-next v2 3/5] cxgb4: add parser to translate u32 filters to internal spec

From: John Fastabend <[email-masked]>
Date: Thu, 15 Sep 2016 07:27:24 -0700

On 16-09-13 04:42 AM, Rahul Lakkireddy wrote:
> Parse information sent by u32 into internal filter specification.
> Add support for parsing several fields in IPv4, IPv6, TCP, and UDP.
> 
> Signed-off-by: Rahul Lakkireddy <[email-masked]>
> Signed-off-by: Hariprasad Shenai <[email-masked]>
> ---

Looks good to me. Also curious if you would find it worthwhile to
have a cls_u32 mode that starts at L2 instead of the IP header? The
use case would be to use cls_u32 with various encapsulation protocols
in front of the IP header.

Reviewed-by: John Fastabend <[email-masked]>