From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: netdev@vger•kernel.org, davem@davemloft•net, idosch@mellanox•com,
eladr@mellanox•com, yotamg@mellanox•com, nogahf@mellanox•com,
ogerlitz@mellanox•com, nikolay@cumulusnetworks•com,
linville@tuxdriver•com, tgraf@suug•ch, gospo@cumulusnetworks•com,
sfeldma@gmail•com, ast@plumgrid•com, edumazet@google•com,
hannes@stressinduktion•org, f.fainelli@gmail•com,
dsa@cumulusnetworks•com, jhs@mojatatu•com,
vivien.didelot@savoirfairelinux•com, john.fastabend@intel•com,
andrew@lunn•ch, ivecera@redhat•com
Subject: Re: [patch net-next RFC 1/2] fib: introduce fib notification infrastructure
Date: Mon, 19 Sep 2016 07:53:07 -0700 [thread overview]
Message-ID: <57DFFBD3.9040906@cumulusnetworks.com> (raw)
In-Reply-To: <20160919060610.GA1846@nanopsycho.orion>
On 9/18/16, 11:06 PM, Jiri Pirko wrote:
> Mon, Sep 19, 2016 at 01:23:47AM CEST, roopa@cumulusnetworks•com wrote:
>> On 9/6/16, 5:01 AM, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@mellanox•com>
>>>
>>> This allows to pass information about added/deleted fib entries to
>>> whoever is interested. This is done in a very similar way as devinet
>>> notifies address additions/removals.
>>>
>>> Signed-off-by: Jiri Pirko <jiri@mellanox•com>
>>> ---
[snip]
>>>
>>> #define KEYLENGTH (8*sizeof(t_key))
>>> @@ -1190,6 +1221,10 @@ int fib_table_insert(struct fib_table *tb, struct fib_config *cfg)
>>> fib_release_info(fi_drop);
>>> if (state & FA_S_ACCESSED)
>>> rt_cache_flush(cfg->fc_nlinfo.nl_net);
>>> +
>>> + call_fib_notifiers(FIB_EVENT_TYPE_ADD, key, plen, fi,
>>> + new_fa->fa_tos, cfg->fc_type,
>>> + tb->tb_id, cfg->fc_nlflags);
>>> rtmsg_fib(RTM_NEWROUTE, htonl(key), new_fa, plen,
>>> tb->tb_id, &cfg->fc_nlinfo, NLM_F_REPLACE);
>>>
>>> @@ -1241,6 +1276,8 @@ int fib_table_insert(struct fib_table *tb, struct fib_config *cfg)
>>> tb->tb_num_default++;
>>>
>>> rt_cache_flush(cfg->fc_nlinfo.nl_net);
>>> + call_fib_notifiers(FIB_EVENT_TYPE_ADD, key, plen, fi, tos,
>>> + cfg->fc_type, tb->tb_id, cfg->fc_nlflags);
>>
>> It appears that this is in addition to the existing switchdev_fib_ipv4_add call right above this.
>> Is the intent to do both ?. i don't see a need to do both.
> I already have patchset improved that it removes the switchdev fib code.
> Have to do some more testing, will send it soon.
ok, ack.
>
>
>> and switchdev_fib_ipv4_add offloads before the route is added to the kernel.
>> But the notifier seems to fire after the route is added to the kernel.
> Yeah, I wanted to align it with rtmsg_fib calls. Also I think it makes
> sense to have slowpath ready before offload.
>
ok, ..but..that changes existing behavior though. and if the hw route add fails...,
you may have inconsistent state between hw and sw.
next prev parent reply other threads:[~2016-09-19 14:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 12:01 [patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes Jiri Pirko
2016-09-06 12:01 ` [patch net-next RFC 1/2] fib: introduce fib notification infrastructure Jiri Pirko
2016-09-06 14:32 ` David Ahern
2016-09-06 14:44 ` Jiri Pirko
2016-09-06 15:11 ` David Ahern
2016-09-06 15:49 ` Jiri Pirko
2016-09-06 16:14 ` Hannes Frederic Sowa
2016-09-06 15:13 ` David Ahern
2016-09-07 8:03 ` Jiri Pirko
2016-09-15 14:41 ` [net-next,RFC,1/2] " Andy Gospodarek
2016-09-15 14:45 ` Jiri Pirko
2016-09-15 14:47 ` Andy Gospodarek
2016-09-18 23:23 ` [patch net-next RFC 1/2] " Roopa Prabhu
2016-09-19 6:06 ` Jiri Pirko
2016-09-19 14:53 ` Roopa Prabhu [this message]
2016-09-19 15:08 ` Jiri Pirko
2016-09-06 12:01 ` [patch net-next RFC 2/2] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls Jiri Pirko
2016-09-18 20:00 ` [patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes Florian Fainelli
2016-09-18 23:16 ` Roopa Prabhu
2016-09-19 6:14 ` Jiri Pirko
2016-09-19 14:59 ` Roopa Prabhu
2016-09-19 15:15 ` Jiri Pirko
2016-09-20 5:49 ` Roopa Prabhu
2016-09-20 6:02 ` Jiri Pirko
2016-09-20 6:18 ` Roopa Prabhu
2016-09-19 6:08 ` Jiri Pirko
2016-09-19 16:44 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57DFFBD3.9040906@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=ast@plumgrid$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=eladr@mellanox$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=hannes@stressinduktion$(echo .)org \
--cc=idosch@mellanox$(echo .)com \
--cc=ivecera@redhat$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@intel$(echo .)com \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=nogahf@mellanox$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
--cc=yotamg@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox