From: Vishwanath Pai <vpai@akamai•com>
To: Jan Engelhardt <jengelh@inai•de>, pablo@netfilter•org
Cc: kaber@trash•net, kadlec@blackhole•kfki.hu, johunt@akamai•com,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
netdev@vger•kernel.org, pai.vishwain@gmail•com
Subject: Re: [PATCH v3 2/2] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates
Date: Thu, 22 Sep 2016 14:39:45 -0400 [thread overview]
Message-ID: <57E42571.1060502@akamai.com> (raw)
In-Reply-To: <alpine.LSU.2.20.1609221850530.27197@nerf40.vanv.qr>
Thanks for pointing this out, I will reorder the fields to:
struct hashlimit_cfg2 {
__u64 avg; /* Average secs between packets * scale */
__u64 burst;
__u32 mode; /* bitmask of XT_HASHLIMIT_HASH_* */
This should fix the hole and avoid padding.
-Vishwanath
On 09/22/2016 12:53 PM, Jan Engelhardt wrote:
> On Thursday 2016-09-22 18:43, Vishwanath Pai wrote:
>> >+struct hashlimit_cfg2 {
>> >+ __u32 mode; /* bitmask of XT_HASHLIMIT_HASH_* */
>> >+ __u64 avg; /* Average secs between packets * scale */
>> >+ __u64 burst; /* Period multiplier for upper limit. */
> This would have different sizes between i386 and x86_64,
> necessiting additional compat functions. It should be padded
> or reordered instead.
>
next prev parent reply other threads:[~2016-09-22 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 16:43 [PATCH v3 2/2] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates Vishwanath Pai
2016-09-22 16:53 ` Jan Engelhardt
2016-09-22 18:39 ` Vishwanath Pai [this message]
2016-09-25 11:35 ` Pablo Neira Ayuso
2016-09-25 12:58 ` Pablo Neira Ayuso
2016-09-27 4:15 ` Liping Zhang
2016-09-27 7:35 ` Vishwanath Pai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57E42571.1060502@akamai.com \
--to=vpai@akamai$(echo .)com \
--cc=coreteam@netfilter$(echo .)org \
--cc=jengelh@inai$(echo .)de \
--cc=johunt@akamai$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=kadlec@blackhole$(echo .)kfki.hu \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=pai.vishwain@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox