From: Vishwanath Pai <vpai@akamai•com>
To: Pablo Neira Ayuso <pablo@netfilter•org>
Cc: johunt@akamai•com, netfilter-devel@vger•kernel.org,
coreteam@netfilter•org, netdev@vger•kernel.org,
pai.vishwain@gmail•com, kaber@trash•net,
kadlec@blackhole•kfki.hu, zlpnobody@gmail•com,
hannes@stressinduktion•org, maze@google•com,
eric.dumazet@gmail•com, akpm@linux-foundation•org
Subject: Re: [PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division
Date: Fri, 30 Sep 2016 13:58:03 -0400 [thread overview]
Message-ID: <57EEA7AB.3010301@akamai.com> (raw)
In-Reply-To: <20160930174650.GE1176@salvia>
On 09/30/2016 01:46 PM, Pablo Neira Ayuso wrote:
> On Thu, Sep 29, 2016 at 01:39:50PM -0400, Vishwanath Pai wrote:
>> v2:
>> Remove unnecessary div64_u64 around constants
>>
>> v3:
>> remove backslashes
>>
>> --
>>
>> Fix link error in 32bit arch because of 64bit division
>>
>> Division of 64bit integers will cause linker error undefined reference
>> to `__udivdi3'. Fix this by replacing divisions with div64_64
>
> Applied, thanks Pai.
>
>> Signed-off-by: Vishwanath Pai <vpai@akamai•com>
>> Fixes: 11d5f15723c9 ("netfilter: xt_hashlimit: Create revision 2 to ...")
>>
>> ---
>
> Please, next time place the versioning information here, otherwise git
> am takes the wrong description here.
>
Thank you. And sorry about, I did not realize git am would put that into
the description.
-Vishwanath
prev parent reply other threads:[~2016-09-30 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 17:39 [PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division Vishwanath Pai
2016-09-30 1:53 ` Maciej Żenczykowski
2016-09-30 17:46 ` Pablo Neira Ayuso
2016-09-30 17:58 ` Vishwanath Pai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57EEA7AB.3010301@akamai.com \
--to=vpai@akamai$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=coreteam@netfilter$(echo .)org \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=hannes@stressinduktion$(echo .)org \
--cc=johunt@akamai$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=kadlec@blackhole$(echo .)kfki.hu \
--cc=maze@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=pai.vishwain@gmail$(echo .)com \
--cc=zlpnobody@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox