Subject: Re: [PATCH -next] net: qcom/emac: fix return value check in emac_sgmii_config()

From: Timur Tabi <[email-masked]>
Date: Mon, 3 Oct 2016 14:41:11 -0500

Wei Yongjun wrote:
> From: Wei Yongjun<[email-masked]>
>
> In case of error, the function ioremap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>
> Also add check for return value of platform_get_resource().
>
> Fixes: 54e19bc74f33 ("net: qcom/emac: do not use devm on internal
> phy pdev")
> Signed-off-by: Wei Yongjun<[email-masked]>

Acked-by: Timur Tabi <[email-masked]>

Thanks for this.  When I switched from devm_ioremap_resource() to 
ioremap(), I didn't think to verify the return values.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.