From: Subash Abhinov Kasiviswanathan <subashab@codeaurora•org>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>,
Eric Dumazet <eric.dumazet@gmail•com>,
Lorenzo Colitti <lorenzo@google•com>
Subject: Re: Use after free in __dst_destroy_metrics_generic
Date: Fri, 08 Sep 2017 13:50:02 -0600 [thread overview]
Message-ID: <57ba5e0dcd50ba74e575051d7f577400@codeaurora.org> (raw)
In-Reply-To: <CAM_iQpXKfUkbyuuZEZXyPrVVCoPaxnCmCARz=Jf0VtU1m9NsZg@mail.gmail.com>
On 2017-09-08 10:10, Cong Wang wrote:
> On Thu, Sep 7, 2017 at 5:52 PM, Subash Abhinov Kasiviswanathan
> <subashab@codeaurora•org> wrote:
>> We are seeing a possible use after free in ip6_dst_destroy.
>>
>> It appears as if memory of the __DST_METRICS_PTR(old) was freed in
>> some path
>> and allocated
>> to ion driver. ion driver has also freed it. Finally the memory is
>> freed by
>> the
>> fib gc and crashes since it is already deallocated.
>
> Does the attach (compile-only) patch help anything?
>
> From my _quick_ glance, it seems we miss the refcnt'ing
> right in __dst_destroy_metrics_generic().
>
> Thanks!
Hi Cong
Thanks for patch. I'll try this out.
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-09-08 19:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 0:52 Use after free in __dst_destroy_metrics_generic Subash Abhinov Kasiviswanathan
2017-09-08 0:56 ` Stefano Brivio
2017-09-08 1:33 ` Subash Abhinov Kasiviswanathan
2017-09-08 16:12 ` Cong Wang
2017-09-08 16:17 ` Stefano Brivio
2017-09-08 2:13 ` David Miller
2017-09-08 3:27 ` Subash Abhinov Kasiviswanathan
2017-09-08 16:10 ` Cong Wang
2017-09-08 17:16 ` Eric Dumazet
2017-09-08 17:19 ` David Miller
2017-09-08 17:28 ` Eric Dumazet
2017-09-08 19:50 ` Subash Abhinov Kasiviswanathan [this message]
2017-09-15 21:00 ` Eric Dumazet
2017-09-15 22:38 ` Julian Anastasov
2017-09-15 23:20 ` Subash Abhinov Kasiviswanathan
2017-09-16 12:40 ` Julian Anastasov
2017-09-16 18:21 ` Cong Wang
2017-09-16 18:13 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57ba5e0dcd50ba74e575051d7f577400@codeaurora.org \
--to=subashab@codeaurora$(echo .)org \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=lorenzo@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox