Subject: Re: [PATCH 2/9] ipv6: sr: add code base for control plane support of SR-IPv6

From: David Lebrun <[email-masked]>
Date: Tue, 18 Oct 2016 13:45:53 +0200

On 10/17/2016 07:07 PM, Tom Herbert wrote:
>> +static inline void seg6_pernet_lock(struct net *net)
>> +{
>> +       mutex_lock(&seg6_pernet(net)->lock);
>> +}
>> +
>> +static inline void seg6_pernet_unlock(struct net *net)
>> +{
>> +       mutex_unlock(&seg6_pernet(net)->lock);
>> +}
>> +
> IMO it's better not to hide mutex_lock/unlock in a static inline
> function. Pairing mutex_lock with mutex_lock is critical and should be
> each to see in code.
> 

OK

>> +
>> +static int seg6_genl_sethmac(struct sk_buff *skb, struct genl_info *info)
>> +{
>> +       return -ENOTSUPP;
> 
> Is the intent to implement this later?
> 

The implementation is in this patch series with the rest of the HMAC code