From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Yotam Gigi <yotamg@mellanox•com>
Cc: Jamal Hadi Salim <jhs@mojatatu•com>,
Jiri Pirko <jiri@resnulli•us>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>,
Ido Schimmel <idosch@mellanox•com>, Elad Raz <eladr@mellanox•com>,
Nogah Frankel <nogahf@mellanox•com>,
Or Gerlitz <ogerlitz@mellanox•com>,
"geert+renesas@glider•be" <geert+renesas@glider•be>,
"stephen@networkplumber•org" <stephen@networkplumber•org>,
"xiyou.wangcong@gmail•com" <xiyou.wangcong@gmail•com>,
"linux@roeck-us•net" <linux@roeck-us•net>,
Shrijeet Mukherjee <shm@cumulusnetworks•com>,
Yotam Gigi <yotam.gi@gmail•com>
Subject: Re: [patch net-next RFC 4/6] Introduce sample tc action
Date: Wed, 19 Oct 2016 00:33:19 -0700 [thread overview]
Message-ID: <580721BF.4010303@cumulusnetworks.com> (raw)
In-Reply-To: <DB3PR05MB0764DA26C8250B6C8DFD537CACD30@DB3PR05MB0764.eurprd05.prod.outlook.com>
On 10/18/16, 3:58 AM, Yotam Gigi wrote:
> On 16-10-15 12:34 PM, Roopa Prabhu wrote:
[snip]
>> The OVS implementation is a good example, the metadata includes all the
>> actions applied
>>>> to the packet in the kernel data path.
>>>>
>>> Again not sure what the use case would be (and why waste such space
>>> especially when you are sending over the wire with such details).
>> All this is being used currently.., But, this can be other api's sflow uses
>> for monitoring.
>> http://openvswitch.org/support/ovscon2014/17/1400-ovs-sflow.pdf
>>
>> Does not have to be part of the main/basic sampling api...
>> it was just an example.
>>
> I guess that making the API extensible solves this, isn't it?
yes, that might help...
Just wanted to bring up the question/clarification on using mark again
tc qdisc add dev eth1 handle ffff: ingress
tc filter add dev eth1 parent ffff: \
matchall action sample rate 12 mark 17
tc filter add parent ffff: dev eth1 protocol all \
u32 match mark 172 0xff
action mirred egress redirect dev dummy0
Like we discussed @ netdev, mark can be used by other things in the system.
A request to sample on an interface cannot be disruptive.
Does this require mark to be not used elsewhere in the system when sampling is enabled on an interface ?
next prev parent reply other threads:[~2016-10-19 14:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 12:41 [patch net-next RFC 0/6] Add support for offloading packet-sampling Jiri Pirko
2016-10-12 12:41 ` [patch net-next RFC 1/6] Introduce ife encapsulation module Jiri Pirko
2016-10-12 12:41 ` [patch net-next RFC 2/6] act_ife: Change to use ife module Jiri Pirko
2016-10-12 12:41 ` [patch net-next RFC 3/6] ife: Introduce new metadata tlv types Jiri Pirko
2016-10-12 12:41 ` [patch net-next RFC 4/6] Introduce sample tc action Jiri Pirko
2016-10-15 16:34 ` Roopa Prabhu
2016-10-15 17:31 ` Roopa Prabhu
2016-10-17 10:10 ` Jamal Hadi Salim
2016-10-18 0:17 ` Roopa Prabhu
2016-10-18 5:07 ` Roopa Prabhu
2016-10-18 10:58 ` Yotam Gigi
2016-10-19 7:33 ` Roopa Prabhu [this message]
2016-10-19 8:28 ` Yotam Gigi
2016-10-16 10:27 ` Or Gerlitz
2016-10-18 8:33 ` Yotam Gigi
2016-10-12 12:41 ` [patch net-next RFC 5/6] mlxsw: reg: add the Monitoring Packet Sampling Configuration Register Jiri Pirko
2016-10-12 12:41 ` [patch net-next RFC 6/6] mlxsw: packet sample: Add packet sample offloading support Jiri Pirko
2016-10-13 7:29 ` [patch net-next RFC 0/6] Add support for offloading packet-sampling Roopa Prabhu
2016-10-13 8:48 ` Jiri Pirko
2016-10-13 11:49 ` Jamal Hadi Salim
2016-10-13 12:10 ` Jiri Pirko
2016-10-13 12:30 ` Jamal Hadi Salim
2016-10-13 12:45 ` Jiri Pirko
2016-10-14 5:02 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=580721BF.4010303@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eladr@mellanox$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=idosch@mellanox$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=linux@roeck-us$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nogahf@mellanox$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=shm@cumulusnetworks$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=xiyou.wangcong@gmail$(echo .)com \
--cc=yotam.gi@gmail$(echo .)com \
--cc=yotamg@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox