From: Daniel Borkmann <daniel@iogearbox•net>
To: Jiri Pirko <jiri@resnulli•us>
Cc: Jamal Hadi Salim <jhs@mojatatu•com>,
davem@davemloft•net, netdev@vger•kernel.org,
xiyou.wangcong@gmail•com, eric.dumazet@gmail•com
Subject: Re: [PATCH net 1/1] net sched filters: fix notification of filter delete with proper handle
Date: Mon, 24 Oct 2016 11:03:19 +0200 [thread overview]
Message-ID: <580DCE57.6070606@iogearbox.net> (raw)
In-Reply-To: <20161024084858.GD2781@nanopsycho>
On 10/24/2016 10:48 AM, Jiri Pirko wrote:
> Mon, Oct 24, 2016 at 12:30:44AM CEST, daniel@iogearbox•net wrote:
>> On 10/23/2016 05:35 PM, Jamal Hadi Salim wrote:
>>> From: Jamal Hadi Salim <jhs@mojatatu•com>
>>
>> An actual commit message would be good especially if it's a fix
>> for -net tree plus stable. Thanks.
>
> Also a "Fixes:" tag would be nice to have :)
This kernel address leakage dates back to history tree:
Fixes: 4e54c4816bfe ("[NET]: Add tc extensions infrastructure.")
>>> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu•com>
>>> ---
>>> net/sched/cls_api.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
>>> index 2ee29a3..2b2a797 100644
>>> --- a/net/sched/cls_api.c
>>> +++ b/net/sched/cls_api.c
>>> @@ -345,7 +345,8 @@ static int tc_ctl_tfilter(struct sk_buff *skb, struct nlmsghdr *n)
>>> if (err == 0) {
>>> struct tcf_proto *next = rtnl_dereference(tp->next);
>>>
>>> - tfilter_notify(net, skb, n, tp, fh,
>>> + tfilter_notify(net, skb, n, tp,
>>> + t->tcm_handle,
>>> RTM_DELTFILTER, false);
>>> if (tcf_destroy(tp, false))
>>> RCU_INIT_POINTER(*back, next);
>>>
>>
next prev parent reply other threads:[~2016-10-24 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 15:35 [PATCH net 1/1] net sched filters: fix notification of filter delete with proper handle Jamal Hadi Salim
2016-10-23 22:30 ` Daniel Borkmann
2016-10-24 8:48 ` Jiri Pirko
2016-10-24 9:03 ` Daniel Borkmann [this message]
2016-10-24 11:28 ` Jamal Hadi Salim
2016-10-24 11:34 ` Daniel Borkmann
2016-10-24 17:02 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=580DCE57.6070606@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox